Support VPC sharing #6642

ewbankkit · 2018-11-29T16:10:30Z

Fixes #6630.
Doing one resource at a time:

ewbankkit · 2018-11-29T16:26:51Z

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSDefaultVpcDhcpOptions_ -timeout 120m
=== RUN   TestAccAWSDefaultVpcDhcpOptions_basic
=== PAUSE TestAccAWSDefaultVpcDhcpOptions_basic
=== CONT  TestAccAWSDefaultVpcDhcpOptions_basic
--- PASS: TestAccAWSDefaultVpcDhcpOptions_basic (13.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.193s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDHCPOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 3 -run=TestAccAWSDHCPOptions_ -timeout 120m
=== RUN   TestAccAWSDHCPOptions_importBasic
=== PAUSE TestAccAWSDHCPOptions_importBasic
=== RUN   TestAccAWSDHCPOptions_basic
=== PAUSE TestAccAWSDHCPOptions_basic
=== RUN   TestAccAWSDHCPOptions_deleteOptions
=== PAUSE TestAccAWSDHCPOptions_deleteOptions
=== CONT  TestAccAWSDHCPOptions_importBasic
=== CONT  TestAccAWSDHCPOptions_deleteOptions
=== CONT  TestAccAWSDHCPOptions_basic
--- PASS: TestAccAWSDHCPOptions_deleteOptions (7.81s)
--- PASS: TestAccAWSDHCPOptions_basic (10.19s)
--- PASS: TestAccAWSDHCPOptions_importBasic (11.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.776s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpcDhcpOptions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 3 -run=TestAccDataSourceAwsVpcDhcpOptions_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_basic
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_basic
=== RUN   TestAccDataSourceAwsVpcDhcpOptions_Filter
=== PAUSE TestAccDataSourceAwsVpcDhcpOptions_Filter
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_basic
=== CONT  TestAccDataSourceAwsVpcDhcpOptions_Filter
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (13.54s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (15.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.938s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 3 -run=TestAccAWSInternetGateway_ -timeout 120m
=== RUN   TestAccAWSInternetGateway_importBasic
=== PAUSE TestAccAWSInternetGateway_importBasic
=== RUN   TestAccAWSInternetGateway_basic
=== PAUSE TestAccAWSInternetGateway_basic
=== RUN   TestAccAWSInternetGateway_delete
=== PAUSE TestAccAWSInternetGateway_delete
=== RUN   TestAccAWSInternetGateway_tags
=== PAUSE TestAccAWSInternetGateway_tags
=== CONT  TestAccAWSInternetGateway_importBasic
=== CONT  TestAccAWSInternetGateway_tags
=== CONT  TestAccAWSInternetGateway_delete
=== CONT  TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_importBasic (27.38s)
--- PASS: TestAccAWSInternetGateway_delete (35.06s)
--- PASS: TestAccAWSInternetGateway_tags (35.83s)
--- PASS: TestAccAWSInternetGateway_basic (48.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.701s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsInternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 3 -run=TestAccDataSourceAwsInternetGateway_ -timeout 120m
=== RUN   TestAccDataSourceAwsInternetGateway_typical
=== PAUSE TestAccDataSourceAwsInternetGateway_typical
=== CONT  TestAccDataSourceAwsInternetGateway_typical
--- PASS: TestAccDataSourceAwsInternetGateway_typical (46.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.402s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultNetworkAcl_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 3 -run=TestAccAWSDefaultNetworkAcl_ -timeout 120m
=== RUN   TestAccAWSDefaultNetworkAcl_basic
=== PAUSE TestAccAWSDefaultNetworkAcl_basic
=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== PAUSE TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== RUN   TestAccAWSDefaultNetworkAcl_deny_ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_deny_ingress
=== RUN   TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetReassign
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetReassign
=== CONT  TestAccAWSDefaultNetworkAcl_basic
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== CONT  TestAccAWSDefaultNetworkAcl_deny_ingress
=== CONT  TestAccAWSDefaultNetworkAcl_withIpv6Ingress
--- PASS: TestAccAWSDefaultNetworkAcl_basic (15.65s)
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (15.95s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetReassign
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (34.24s)
=== CONT  TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (20.47s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (18.90s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (44.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.762s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSNetworkAcl_EgressAndIngressRules'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSNetworkAcl_EgressAndIngressRules -timeout 120m
=== RUN   TestAccAWSNetworkAcl_EgressAndIngressRules
=== PAUSE TestAccAWSNetworkAcl_EgressAndIngressRules
=== CONT  TestAccAWSNetworkAcl_EgressAndIngressRules
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (37.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.478s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSNetworkAcl_OnlyIngressRules_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSNetworkAcl_OnlyIngressRules_ -timeout 120m
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_update
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_update
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_basic
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (42.35s)
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_update
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (42.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	104.008s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSDefaultRouteTable_ -timeout 120m
=== RUN   TestAccAWSDefaultRouteTable_basic
=== PAUSE TestAccAWSDefaultRouteTable_basic
=== RUN   TestAccAWSDefaultRouteTable_swap
=== PAUSE TestAccAWSDefaultRouteTable_swap
=== RUN   TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== PAUSE TestAccAWSDefaultRouteTable_Route_TransitGatewayID
=== RUN   TestAccAWSDefaultRouteTable_vpc_endpoint
=== PAUSE TestAccAWSDefaultRouteTable_vpc_endpoint
=== CONT  TestAccAWSDefaultRouteTable_basic
=== CONT  TestAccAWSDefaultRouteTable_vpc_endpoint
--- PASS: TestAccAWSDefaultRouteTable_basic (34.02s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (47.58s)
=== CONT  TestAccAWSDefaultRouteTable_Route_TransitGatewayID
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (206.96s)
=== CONT  TestAccAWSDefaultRouteTable_swap
--- PASS: TestAccAWSDefaultRouteTable_swap (66.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	355.691s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSRouteTable_basic -timeout 120m
=== RUN   TestAccAWSRouteTable_basic
=== PAUSE TestAccAWSRouteTable_basic
=== CONT  TestAccAWSRouteTable_basic
--- PASS: TestAccAWSRouteTable_basic (77.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	78.544s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRouteTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccDataSourceAwsRouteTable_ -timeout 120m
=== RUN   TestAccDataSourceAwsRouteTable_basic
=== PAUSE TestAccDataSourceAwsRouteTable_basic
=== RUN   TestAccDataSourceAwsRouteTable_main
=== PAUSE TestAccDataSourceAwsRouteTable_main
=== CONT  TestAccDataSourceAwsRouteTable_basic
--- PASS: TestAccDataSourceAwsRouteTable_basic (71.90s)
=== CONT  TestAccDataSourceAwsRouteTable_main
--- PASS: TestAccDataSourceAwsRouteTable_main (22.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	95.381s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultSubnet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSDefaultSubnet_ -timeout 120m
=== RUN   TestAccAWSDefaultSubnet_basic
=== PAUSE TestAccAWSDefaultSubnet_basic
=== RUN   TestAccAWSDefaultSubnet_publicIp
=== PAUSE TestAccAWSDefaultSubnet_publicIp
=== CONT  TestAccAWSDefaultSubnet_basic
=== CONT  TestAccAWSDefaultSubnet_publicIp
--- PASS: TestAccAWSDefaultSubnet_basic (14.36s)
--- PASS: TestAccAWSDefaultSubnet_publicIp (25.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.924s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSubnet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSSubnet_basic -timeout 120m
=== RUN   TestAccAWSSubnet_basic
=== PAUSE TestAccAWSSubnet_basic
=== CONT  TestAccAWSSubnet_basic
--- PASS: TestAccAWSSubnet_basic (54.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.286s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsSubnet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccDataSourceAwsSubnet_ -timeout 120m
=== RUN   TestAccDataSourceAwsSubnet_basic
=== PAUSE TestAccDataSourceAwsSubnet_basic
=== RUN   TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter
=== PAUSE TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter
=== RUN   TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock
=== PAUSE TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock
=== CONT  TestAccDataSourceAwsSubnet_basic
--- PASS: TestAccDataSourceAwsSubnet_basic (35.37s)
=== CONT  TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (59.12s)
=== CONT  TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (114.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	209.611s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSDefaultVpc_ -timeout 120m
=== RUN   TestAccAWSDefaultVpc_basic
=== PAUSE TestAccAWSDefaultVpc_basic
=== CONT  TestAccAWSDefaultVpc_basic
--- PASS: TestAccAWSDefaultVpc_basic (53.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	54.659s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpc_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccAWSVpc_basic -timeout 120m
=== RUN   TestAccAWSVpc_basic
=== PAUSE TestAccAWSVpc_basic
=== CONT  TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (54.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.258s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel  1 -run=TestAccDataSourceAwsVpc_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpc_basic
=== PAUSE TestAccDataSourceAwsVpc_basic
=== RUN   TestAccDataSourceAwsVpc_ipv6Associated
=== PAUSE TestAccDataSourceAwsVpc_ipv6Associated
=== RUN   TestAccDataSourceAwsVpc_multipleCidr
=== PAUSE TestAccDataSourceAwsVpc_multipleCidr
=== CONT  TestAccDataSourceAwsVpc_basic
=== CONT  TestAccDataSourceAwsVpc_multipleCidr
--- PASS: TestAccDataSourceAwsVpc_basic (47.87s)
--- PASS: TestAccDataSourceAwsVpc_multipleCidr (86.71s)
=== CONT  TestAccDataSourceAwsVpc_ipv6Associated
--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (53.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	188.765s

ewbankkit · 2018-11-29T21:36:53Z

Removed WIP. Ready for review.

ewbankkit · 2018-11-30T15:57:25Z

Back to WIP until I add support for AZ ID to Subnet creation; See #6546 (comment).

bflad

Thanks for this, @ewbankkit! Some minor testing/documentation updates then we'll double check the acceptance testing and 🚢 this. 😄

bflad · 2018-11-30T19:07:56Z

aws/data_source_aws_internet_gateway_test.go

@@ -53,6 +53,14 @@ func testAccDataSourceAwsInternetGatewayCheck(name string) resource.TestCheckFun
 			)
 		}

+		if attr["owner_id"] != igwRs.Primary.Attributes["owner_id"] {


Not necessarily for this PR, but we can use resource.TestCheckResourceAttrPair() instead of this custom logic. I'm not opposed to starting with just these new attributes to start that technical debt cleanup.

Same applies below to other similar logic. 👍

Yeah, I added that function back in Feb 2017 😄. OK, I'll use it here.

Similar changes to

data_source_aws_route_table_test.go

data_source_aws_subnet_test.go

data_source_aws_vpc_test.go.

aws/data_source_aws_subnet.go

bflad · 2018-11-30T19:11:34Z

aws/resource_aws_default_network_acl_test.go

@@ -38,6 +38,7 @@ func TestAccAWSDefaultNetworkAcl_basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccGetAWSDefaultNetworkAcl("aws_default_network_acl.default", &networkAcl),
 					testAccCheckAWSDefaultACLAttributes(&networkAcl, []*ec2.NetworkAclEntry{}, 0, 2),
+					resource.TestCheckResourceAttrSet("aws_default_network_acl.default", "owner_id"),


Instead of allowing any value here (e.g. d.Set("owner_id", "not-an-account-id-attribute")), we can verify this via the following recent addition to the acceptance testing utility functions:

Suggested change

resource.TestCheckResourceAttrSet("aws_default_network_acl.default", "owner_id"),

testAccCheckResourceAttrAccountID("aws_default_network_acl.default", "owner_id"),

The same applies to other similar new resource.TestCheckResourceAttrSet() calls below.

OK, will do. Good to know.

Similar changes to

resource_aws_default_route_table_test.go

resource_aws_default_subnet_test.go

resource_aws_default_vpc_dhcp_options_test.go

resource_aws_ec2_transit_gateway_test.go

resource_aws_internet_gateway_test.go

resource_aws_network_acl_test.go

resource_aws_route_table_test.go

resource_aws_subnet_test.go

resource_aws_vpc_dhcp_options_test.go

resource_aws_default_vpc_test.go

resource_aws_vpc_test.go

aws/resource_aws_default_vpc_dhcp_options.go

aws/resource_aws_default_vpc_test.go

bflad · 2018-11-30T19:19:51Z

aws/resource_aws_internet_gateway.go

-	return resourceAwsInternetGatewayAttach(d, meta)
+	err = resourceAwsInternetGatewayAttach(d, meta)
+	if err != nil {
+		return err


We might want to return some context about when this error occurs since the conn.AttachInternetGateway call does not, e.g.

Suggested change

return err

return fmt.Errorf("error attaching EC2 Internet Gateway (%s): %s", d.Id(), err)

OK, will do.

aws/resource_aws_vpc_dhcp_options.go

bflad · 2018-12-02T00:33:44Z

@ewbankkit do you need to push up your changes or is GitHub being weird? 😄 Thanks so much.

ewbankkit · 2018-12-02T20:00:18Z

@bflad No, that was me just making a note of progress as I made the review changes.
I've now pushed the changes after the code review and additional the changes to support AvailabilityZoneId for subnets which is necessary for VPC sharing. The equivalent change for creating default subnets will have to wait until #4957 is done.
Acceptance tests for the subnet changes:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSubnet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 1 -run=TestAccAWSSubnet_ -timeout 120m
=== RUN   TestAccAWSSubnet_importBasic
=== PAUSE TestAccAWSSubnet_importBasic
=== RUN   TestAccAWSSubnet_basic
=== PAUSE TestAccAWSSubnet_basic
=== RUN   TestAccAWSSubnet_ipv6
=== PAUSE TestAccAWSSubnet_ipv6
=== RUN   TestAccAWSSubnet_enableIpv6
=== PAUSE TestAccAWSSubnet_enableIpv6
=== RUN   TestAccAWSSubnet_availabilityZoneId
=== PAUSE TestAccAWSSubnet_availabilityZoneId
=== CONT  TestAccAWSSubnet_importBasic
--- PASS: TestAccAWSSubnet_importBasic (30.49s)
=== CONT  TestAccAWSSubnet_availabilityZoneId
--- PASS: TestAccAWSSubnet_availabilityZoneId (27.82s)
=== CONT  TestAccAWSSubnet_enableIpv6
--- PASS: TestAccAWSSubnet_enableIpv6 (47.20s)
=== CONT  TestAccAWSSubnet_ipv6
--- PASS: TestAccAWSSubnet_ipv6 (75.59s)
=== CONT  TestAccAWSSubnet_basic
--- PASS: TestAccAWSSubnet_basic (29.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	210.172s

I made changes to the data source tests to avoid dependence on a particular region and ran in us-east-2 to verify:

$ AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsSubnet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 1 -run=TestAccDataSourceAwsSubnet_ -timeout 120m
=== RUN   TestAccDataSourceAwsSubnet_basic
=== PAUSE TestAccDataSourceAwsSubnet_basic
=== RUN   TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter
=== PAUSE TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter
=== RUN   TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock
=== PAUSE TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock
=== CONT  TestAccDataSourceAwsSubnet_basic
--- PASS: TestAccDataSourceAwsSubnet_basic (17.56s)
=== CONT  TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (28.15s)
=== CONT  TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (28.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	73.726s

aws/resource_aws_default_subnet.go

bflad

LGTM, thanks @ewbankkit! 🚀

--- PASS: TestAccAWSDefaultNetworkAcl_basic (26.50s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (20.00s)
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (24.12s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (60.47s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (40.55s)
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (20.61s)
--- PASS: TestAccAWSDefaultRouteTable_basic (33.16s)
--- PASS: TestAccAWSDefaultRouteTable_Route_TransitGatewayID (259.91s)
--- PASS: TestAccAWSDefaultRouteTable_swap (58.03s)
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (221.27s)
--- PASS: TestAccAWSDefaultSubnet_basic (15.55s)
--- PASS: TestAccAWSDefaultSubnet_publicIp (24.58s)
--- PASS: TestAccAWSDefaultVpc_basic (14.43s)
--- PASS: TestAccAWSDHCPOptions_basic (5.93s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (8.47s)
--- PASS: TestAccAWSDHCPOptions_importBasic (9.19s)
--- PASS: TestAccAWSEc2TransitGateway_basic (155.44s)
--- PASS: TestAccAWSInternetGateway_basic (62.34s)
--- PASS: TestAccAWSInternetGateway_delete (34.37s)
--- PASS: TestAccAWSInternetGateway_importBasic (34.68s)
--- PASS: TestAccAWSInternetGateway_tags (36.89s)
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (44.72s)
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (14.07s)
--- PASS: TestAccAWSNetworkAcl_espProtocol (20.57s)
--- PASS: TestAccAWSNetworkAcl_importBasic (38.67s)
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (17.09s)
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (29.18s)
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (33.28s)
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (27.02s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (28.47s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (27.09s)
--- PASS: TestAccAWSNetworkAcl_SubnetChange (63.63s)
--- PASS: TestAccAWSNetworkAcl_Subnets (55.55s)
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (51.88s)
--- PASS: TestAccAWSRouteTable_basic (48.57s)
--- PASS: TestAccAWSRouteTable_complex (181.18s)
--- PASS: TestAccAWSRouteTable_importBasic (59.67s)
--- PASS: TestAccAWSRouteTable_instance (120.44s)
--- PASS: TestAccAWSRouteTable_ipv6 (29.64s)
--- PASS: TestAccAWSRouteTable_panicEmptyRoute (10.50s)
--- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (210.58s)
--- PASS: TestAccAWSRouteTable_tags (40.26s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (32.20s)
--- PASS: TestAccAWSRouteTable_vpcPeering (107.47s)
--- PASS: TestAccAWSSubnet_availabilityZoneId (22.81s)
--- PASS: TestAccAWSSubnet_basic (14.45s)
--- PASS: TestAccAWSSubnet_enableIpv6 (65.36s)
--- PASS: TestAccAWSSubnet_importBasic (20.26s)
--- PASS: TestAccAWSSubnet_ipv6 (76.85s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (58.69s)
--- PASS: TestAccAWSVpc_basic (43.60s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (24.37s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (10.73s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (13.38s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (14.51s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (16.35s)
--- PASS: TestAccAWSVpc_tags (48.68s)
--- PASS: TestAccAWSVpc_Tenancy (52.53s)
--- PASS: TestAccAWSVpc_update (38.37s)
--- PASS: TestAccDataSourceAwsInternetGateway_typical (51.84s)
--- PASS: TestAccDataSourceAwsRouteTable_basic (42.32s)
--- PASS: TestAccDataSourceAwsRouteTable_main (19.59s)
--- PASS: TestAccDataSourceAwsSubnet_basic (30.94s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (26.86s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (51.08s)
--- PASS: TestAccDataSourceAwsVpc_basic (63.38s)
--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (25.54s)
--- PASS: TestAccDataSourceAwsVpc_multipleCidr (30.77s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_basic (31.09s)
--- PASS: TestAccDataSourceAwsVpcDhcpOptions_Filter (26.59s)

bflad · 2018-12-05T22:25:35Z

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-02T17:11:46Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Support VPC sharing - aws_vpc_dhcp_options.

b523e18

Support VPC sharing - aws_internet_gateway.

f5ded05

ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 29, 2018

Kit Ewbank added 3 commits November 29, 2018 12:07

Support VPC sharing - aws_default_network_acl/aws_network_acl.

cfacf61

Support VPC sharing - aws_default_route_table/aws_route_table.

0692bf7

Support VPC sharing - aws_default_subnet/aws_subnet.

53fe54c

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 29, 2018

Kit Ewbank added 3 commits November 29, 2018 13:18

Support VPC sharing - aws_default_vpc/aws_vpc.

eac7129

Support VPC sharing - aws_default_vpc_dhcp_options.

97d1f64

Fix NACL acceptance test.

840a8b6

ewbankkit changed the title ~~[WIP] Support VPC sharing~~ Support VPC sharing Nov 29, 2018

bflad reviewed Nov 30, 2018

View reviewed changes

bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Nov 30, 2018

ewbankkit commented Nov 30, 2018

View reviewed changes

aws/resource_aws_vpc_dhcp_options.go Show resolved Hide resolved

Changes after first code review.

b8a2a4a

bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 2, 2018

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 2, 2018

Support Availability Zone ID for Subnets.

71e1147

ghost removed the size/L Managed by automation to categorize the size of a PR. label Dec 2, 2018

ghost added the size/XL Managed by automation to categorize the size of a PR. label Dec 2, 2018

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 2, 2018

bflad reviewed Dec 3, 2018

View reviewed changes

aws/resource_aws_default_subnet.go Show resolved Hide resolved

Corrections for aws_default_subnet resource.

92eb437

bflad added this to the v1.51.0 milestone Dec 4, 2018

bflad approved these changes Dec 4, 2018

View reviewed changes

bflad merged commit d897abe into hashicorp:master Dec 4, 2018

bflad added a commit that referenced this pull request Dec 4, 2018

Update CHANGELOG for #6642

712affd

ewbankkit deleted the issue-6630 branch December 4, 2018 11:22

tyler-luminal mentioned this pull request Feb 21, 2019

[RM-1480] Suppress InvalidVpcID.NotFound on describe VPC classic link calls LuminalHQ/terraform-provider-aws#5

Merged

ghost locked and limited conversation to collaborators Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support VPC sharing #6642

Support VPC sharing #6642

ewbankkit commented Nov 29, 2018 •

edited

Loading

ewbankkit commented Nov 29, 2018 •

edited

Loading

ewbankkit commented Nov 29, 2018

ewbankkit commented Nov 30, 2018

bflad left a comment

bflad Nov 30, 2018

ewbankkit Nov 30, 2018

ewbankkit Nov 30, 2018 •

edited

Loading

ewbankkit Nov 30, 2018

bflad Nov 30, 2018

ewbankkit Nov 30, 2018

ewbankkit Nov 30, 2018 •

edited

Loading

ewbankkit Nov 30, 2018

bflad Nov 30, 2018

ewbankkit Nov 30, 2018

ewbankkit Nov 30, 2018

bflad commented Dec 2, 2018

ewbankkit commented Dec 2, 2018

bflad left a comment

bflad commented Dec 5, 2018

ghost commented Apr 2, 2020

	resource.TestCheckResourceAttrSet("aws_default_network_acl.default", "owner_id"),
	testAccCheckResourceAttrAccountID("aws_default_network_acl.default", "owner_id"),

	return err
	return fmt.Errorf("error attaching EC2 Internet Gateway (%s): %s", d.Id(), err)

Support VPC sharing #6642

Support VPC sharing #6642

Conversation

ewbankkit commented Nov 29, 2018 • edited Loading

ewbankkit commented Nov 29, 2018 • edited Loading

ewbankkit commented Nov 29, 2018

ewbankkit commented Nov 30, 2018

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewbankkit Nov 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewbankkit Nov 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bflad commented Dec 2, 2018

ewbankkit commented Dec 2, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad commented Dec 5, 2018

ghost commented Apr 2, 2020

ewbankkit commented Nov 29, 2018 •

edited

Loading

ewbankkit commented Nov 29, 2018 •

edited

Loading

ewbankkit Nov 30, 2018 •

edited

Loading

ewbankkit Nov 30, 2018 •

edited

Loading