Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_appmesh_mesh resource #6708

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Add aws_appmesh_mesh resource #6708

merged 2 commits into from
Dec 4, 2018

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 4, 2018 •
edited
Loading

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 4, 2018
@ewbankkit
Copy link
Contributor Author

Acceptance tests so far:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAppmeshMesh_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsAppmeshMesh_ -timeout 120m
=== RUN   TestAccAwsAppmeshMesh_importBasic
--- PASS: TestAccAwsAppmeshMesh_importBasic (20.56s)
=== RUN   TestAccAwsAppmeshMesh_basic
--- PASS: TestAccAwsAppmeshMesh_basic (14.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.866s

ewbankkit
ewbankkit commented Dec 4, 2018
View reviewed changes
aws/resource_aws_appmesh_mesh_test.go Outdated
resourceName := "aws_appmesh_mesh.foo"
rName := fmt.Sprintf("tf-test-%d", acctest.RandInt())

resource.Test(t, resource.TestCase{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one service mesh per account allowed right now, so no parallel tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still parallelized across function names in our CI environment so a setup similar to TestAccAWSGuardduty is required. 👍

@ewbankkit
Copy link
Contributor Author

@bflad Do you want all resources in a single PR?

@bflad bflad added new-resource Introduces a new resource. service/appmesh Issues and PRs that pertain to the appmesh service. labels Dec 4, 2018
bflad
bflad reviewed Dec 4, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally still prefer 1 resource per PR to keep reviews simple (and not repeat comments across files). For example, this is pretty good to go except for minor things and we can get it merged in shortly after. 😄

aws/resource_aws_appmesh_mesh_test.go Outdated
resourceName := "aws_appmesh_mesh.foo"
rName := fmt.Sprintf("tf-test-%d", acctest.RandInt())

resource.Test(t, resource.TestCase{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still parallelized across function names in our CI environment so a setup similar to TestAccAWSGuardduty is required. 👍

aws/resource_aws_appmesh_mesh_test.go Outdated
},
{
ResourceName: resourceName,
ImportState: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to put the ImportState test step in each acceptance test instead of separate and duplicate testing. 👍

website/aws.erb Outdated
<li<%= sidebar_current("docs-aws-resource-appmesh-mesh") %>>
<a href="/docs/providers/aws/r/appmesh_mesh.html">aws_appmesh_mesh</a>
</li>
<li<%= sidebar_current("docs-aws-resource-appmesh-mesh") %>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extraneous line 😎

website/aws.erb Outdated
@@ -515,6 +515,16 @@
</ul>
</li>

<li<%= sidebar_current("docs-aws-resource-appmesh") %>>
<a href="#">AppSync Resources</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍝 Copy-pasta

Suggested change
<a href="#">AppSync Resources</a>
<a href="#">AppMesh Resources</a>

@ewbankkit ewbankkit changed the title Support AWS App Mesh Add aws_appmesh_mesh resource Dec 4, 2018
@ewbankkit
Copy link
Contributor Author

Changes made after code review.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/basic
--- PASS: TestAccAWSAppmesh (18.22s)
    --- PASS: TestAccAWSAppmesh/Mesh (18.22s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (18.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.171s

@ewbankkit
Copy link
Contributor Author

I retitled this PR to reflect the single resource being added.

@ewbankkit ewbankkit mentioned this pull request Dec 4, 2018
Closed
@bflad bflad added this to the v1.51.0 milestone Dec 4, 2018
bflad
bflad approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAppmesh (11.55s)
    --- PASS: TestAccAWSAppmesh/Mesh (11.55s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (11.55s)

@bflad bflad merged commit 7cebbf5 into hashicorp:master Dec 4, 2018
bflad added a commit that referenced this pull request Dec 4, 2018
@bflad
Update CHANGELOG for #6708
e2e548c
@ewbankkit ewbankkit mentioned this pull request Dec 4, 2018
Merged
@ewbankkit ewbankkit deleted the issue-6707 branch December 5, 2018 18:41
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

This was referenced Dec 7, 2018
Merged
Merged
@ewbankkit ewbankkit mentioned this pull request Feb 4, 2019
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.51.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @bflad