Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Return error instead of logging on AWS Account ID lookup failure during initialization #7737

Merged
merged 1 commit into from
Feb 27, 2019
Merged

provider: Return error instead of logging on AWS Account ID lookup failure during initialization #7737

merged 1 commit into from
Feb 27, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 27, 2019

Closes #7674
Additional reference: #5795

Updated via:

$ go get github.com/hashicorp/aws-sdk-go-base@v0.3.0
$ go mod tidy
$ go mod vendor

@bflad
provider: Return error instead of logging on AWS Account ID lookup fa…
4176d50 
…ilure during initialization

References:
* #7674
* #5795

Updated via:

```
$ go get github.com/hashicorp/aws-sdk-go-base@v0.3.0
$ go mod tidy
$ go mod vendor
```
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 27, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 27, 2019
@bflad bflad requested a review from a team February 27, 2019 01:37
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Feb 27, 2019
nywilken
nywilken approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit c1a7ddb into master Feb 27, 2019
@bflad bflad deleted the td-provider-account-id-lookup-error branch February 27, 2019 11:57
bflad added a commit that referenced this pull request Feb 27, 2019
@bflad
Update CHANGELOG for #7737
aee5d93
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.0.0
2 participants
@bflad @nywilken