Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Return error instead of WARN log with AWS account ID lookup failure #5795

Closed
wants to merge 1 commit into from
Closed

provider: Return error instead of WARN log with AWS account ID lookup failure #5795

wants to merge 1 commit into from

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 5, 2018

Followup to: #5794

This change is already noted in the Version 2 Upgrade Guide.

Output from acceptance testing: N/A

@bflad
provider: Return error instead of WARN log with AWS account ID lookup…
9e67bec 
… failure

Followup to: #5794

This change is already noted in the Version 2 Upgrade Guide.
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 5, 2018
@bflad bflad added this to the v2.0.0 milestone Sep 5, 2018
@bflad bflad requested a review from a team September 5, 2018 15:04
tombuildsstuff
tombuildsstuff approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad mentioned this pull request Feb 24, 2019
Closed
@bflad
Copy link
Contributor Author

bflad commented Feb 24, 2019

Closing this PR due to #7653 -- we will still be making this change though, tracking issue: #7674

@bflad bflad closed this Feb 24, 2019
@bflad bflad deleted the td-provider-skip_requesting_account_id-error-v2 branch February 24, 2019 16:27
bflad added a commit to hashicorp/aws-sdk-go-base that referenced this pull request Feb 27, 2019
@bflad
session: Return error instead of logging with AWS Account ID lookup f…
0de5f5f 
…ailure

References:
* hashicorp/terraform-provider-aws#7674
* hashicorp/terraform-provider-aws#5795
@bflad bflad mentioned this pull request Feb 27, 2019
Merged
bflad added a commit that referenced this pull request Feb 27, 2019
@bflad
provider: Return error instead of logging on AWS Account ID lookup fa…
4176d50 
…ilure during initialization

References:
* #7674
* #5795

Updated via:

```
$ go get github.com/hashicorp/aws-sdk-go-base@v0.3.0
$ go mod tidy
$ go mod vendor
```
@bflad bflad mentioned this pull request Feb 27, 2019
Merged
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. provider Pertains to the provider itself, rather than any interaction with AWS.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff