provider: WARN log instead of returning error with AWS account ID lookup logic #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kup logic Reinstates provider behavior previous to version 1.31.0 which silently allowed AWS account ID lookup failures during initialization. Since missing the AWS account ID in the provider has implications for quite a few data sources and resources, we will return the error in the next major version of the provider. * Replace error from provider AWS account ID lookup with WARN log message * Add information about change in behavior to Version 2 Upgrade Guide
bflad
added
bug
This was referenced Sep 5, 2018
bflad
added a commit
that referenced
this pull request
Sep 5, 2018
… failure Followup to: #5794 This change is already noted in the Version 2 Upgrade Guide.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstates provider behavior previous to version 1.31.0 which silently allowed AWS account ID lookup failures during initialization. Since missing the AWS account ID in the provider has implications for quite a few data sources and resources, we will return the error in the next major version of the provider.
Fixes #5584
Fixes #5496
Changes proposed in this pull request:
Output from acceptance testing: (provided as a smoke test)