Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Glacier Deep Archive storage class #8109

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

sunilkumarmohanty
Copy link
Contributor

Fixes #8106

Changes proposed in this pull request:

  • Support for DEEP_ARCHIVE s3 storage class

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=^TestAccAWSS3Bucket_Lifecycle$'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=^TestAccAWSS3Bucket_Lifecycle -timeout 120m
=== RUN   TestAccAWSS3Bucket_Lifecycle
=== PAUSE TestAccAWSS3Bucket_Lifecycle
=== RUN   TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== PAUSE TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== CONT  TestAccAWSS3Bucket_Lifecycle
=== CONT  TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (103.26s)
--- PASS: TestAccAWSS3Bucket_Lifecycle (155.07s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       155.122s


$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3BucketObject_storageClass'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSS3BucketObject_storageClass -timeout 120m
=== RUN   TestAccAWSS3BucketObject_storageClass
=== PAUSE TestAccAWSS3BucketObject_storageClass
=== CONT  TestAccAWSS3BucketObject_storageClass
--- PASS: TestAccAWSS3BucketObject_storageClass (224.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       224.970s
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 28, 2019
@sunilkumarmohanty sunilkumarmohanty changed the title 8106 glacier deep archive Add support for Glacier Deep Archive storage class Mar 28, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 28, 2019
@bflad bflad added this to the v2.4.0 milestone Mar 28, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @sunilkumarmohanty! Thanks so much for adding the testing.

--- PASS: TestAccAWSS3BucketObject_storageClass (108.52s)

--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (52.01s)
--- PASS: TestAccAWSS3Bucket_Lifecycle (74.91s)

@@ -903,6 +903,7 @@ func validateS3BucketLifecycleTransitionStorageClass() schema.SchemaValidateFunc
s3.TransitionStorageClassStandardIa,
s3.TransitionStorageClassOnezoneIa,
s3.TransitionStorageClassIntelligentTiering,
s3.StorageClassDeepArchive,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Looks like there is an AWS Go SDK constant to match the others in this function: TransitionStorageClassDeepArchive -- will adjust this on merge so we can release this today.

@bflad bflad merged commit c658c74 into hashicorp:master Mar 28, 2019
bflad added a commit that referenced this pull request Mar 28, 2019
@bflad
Copy link
Contributor

bflad commented Mar 29, 2019

This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_s3_bucket_object: Add support for Glacier Deep Archive storage class
2 participants