Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configurable timeouts in AWS OpsWorks Instances. #857

Conversation

charles-at-geospock
Copy link
Contributor

We have found that the creation and update of the OpsWorks Instances often
times out with the default 10 minute timeout. This change introduces a
configuration for 'Create', 'Delete' and 'Update' timeouts. The actual
implementation is required to start or stop the instance, which is the
operation which times out, and which of these is performed (particularly
for the 'Update' operation) is dependant on the change needed.

The change introduces the timeouts, adds a simple test that the format
is parsed, and provides documentation for these new parameters.

We have found that the creation and update of the OpsWorks Instances often
times out with the default 10 minute timeout. This change introduces a
configuration for 'Create', 'Delete' and 'Update' timeouts. The actual
implementation is required to start or stop the instance, which is the
operation which times out, and which of these is performed (particularly
for the 'Update' operation) is dependant on the change needed.

The change introduces the timeouts, adds a simple test that the format
is parsed, and provides documentation for these new parameters.
@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 14, 2017
@stack72
Copy link
Contributor

stack72 commented Jun 14, 2017

Thanks so much for moving this PR and for the functionality update :) This LGTM!

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSOpsworksInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSOpsworksInstance_ -timeout 120m
=== RUN   TestAccAWSOpsworksInstance_importBasic
--- PASS: TestAccAWSOpsworksInstance_importBasic (139.33s)
=== RUN   TestAccAWSOpsworksInstance_UpdateHostNameForceNew
--- PASS: TestAccAWSOpsworksInstance_UpdateHostNameForceNew (168.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	307.625s

@stack72 stack72 merged commit da20c3e into hashicorp:master Jun 14, 2017
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants