r/lambda_function: support nodejs 10.x runtime

[acburdine]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8627

Release note for CHANGELOG:

resource/aws_lambda_function: support nodejs10.x runtime

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_runtimeValidation'
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (2.38s)
--- FAIL: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (34.05s)
    testing.go:568: Step 0 error: errors during apply:

        Error: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
                status code: 400, request id: c627d505-aca2-404b-9df4-19049657e699

          on /var/folders/5_/yp4n1h313nnck0dh22h7bzt4nbtrkm/T/tf-test266518313/main.tf line 73:
          (source code not available)


--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (38.86s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs810 (38.90s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (40.74s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (40.85s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (43.05s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (45.29s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (47.04s)

Looks like it failed on trying to create another VPC.......must be an issue with the specific account I ran this in, everything else looked fine.

[bflad]

Looks great, thanks for the additional test, @acburdine! 🚀

--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (43.24s)

[chintan-patel]

@bflad I am desperately waiting for Lamdba Runtime Node.js 10?

Is there any schedule/frequency followed to release patches ?

[bflad]

@chintan-patel typically weekly (roughly Thursdays) see also the repository CHANGELOG: https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md

[chintan-patel]

Thank you I ll look

[bflad]

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[shadycuz]

@acburdine @bflad This fix made it into 2.11 but I need this in 2.4 to test other bug fixes with api gateway stage and deployment resources. What is the best way to make this happen?

@monteith

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!