Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retries after timeouts for various Neptune resources #9036

Merged
merged 4 commits into from
Jun 19, 2019
Merged

Final retries after timeouts for various Neptune resources #9036

merged 4 commits into from
Jun 19, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_neptune_cluster: Final retries when creating, updating, and deleting Neptune clusters
* resource/aws_neptune_cluster_instance: Final retries creating and updating cluster instances
* resource/aws_neptune_parameter_group: Final retries updating and deleting parameter groups

Output from acceptance testing:

make testacc TESTARGS="-run=TestAccAWSNeptuneCluster"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSNeptuneCluster -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSNeptuneClusterInstance_basic
=== PAUSE TestAccAWSNeptuneClusterInstance_basic
=== RUN   TestAccAWSNeptuneClusterInstance_withaz
=== PAUSE TestAccAWSNeptuneClusterInstance_withaz
=== RUN   TestAccAWSNeptuneClusterInstance_namePrefix
=== PAUSE TestAccAWSNeptuneClusterInstance_namePrefix
=== RUN   TestAccAWSNeptuneClusterInstance_withSubnetGroup
=== PAUSE TestAccAWSNeptuneClusterInstance_withSubnetGroup
=== RUN   TestAccAWSNeptuneClusterInstance_generatedName
=== PAUSE TestAccAWSNeptuneClusterInstance_generatedName
=== RUN   TestAccAWSNeptuneClusterInstance_kmsKey
=== PAUSE TestAccAWSNeptuneClusterInstance_kmsKey
=== RUN   TestAccAWSNeptuneClusterParameterGroup_basic
=== PAUSE TestAccAWSNeptuneClusterParameterGroup_basic
=== RUN   TestAccAWSNeptuneClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSNeptuneClusterParameterGroup_namePrefix
=== RUN   TestAccAWSNeptuneClusterParameterGroup_generatedName
=== PAUSE TestAccAWSNeptuneClusterParameterGroup_generatedName
=== RUN   TestAccAWSNeptuneClusterParameterGroup_Description
=== PAUSE TestAccAWSNeptuneClusterParameterGroup_Description
=== RUN   TestAccAWSNeptuneClusterParameterGroup_Parameter
=== PAUSE TestAccAWSNeptuneClusterParameterGroup_Parameter
=== RUN   TestAccAWSNeptuneClusterParameterGroup_Tags
=== PAUSE TestAccAWSNeptuneClusterParameterGroup_Tags
=== RUN   TestAccAWSNeptuneClusterSnapshot_basic
=== PAUSE TestAccAWSNeptuneClusterSnapshot_basic
=== RUN   TestAccAWSNeptuneCluster_basic
=== PAUSE TestAccAWSNeptuneCluster_basic
=== RUN   TestAccAWSNeptuneCluster_namePrefix
=== PAUSE TestAccAWSNeptuneCluster_namePrefix
=== RUN   TestAccAWSNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccAWSNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccAWSNeptuneCluster_updateTags
=== PAUSE TestAccAWSNeptuneCluster_updateTags
=== RUN   TestAccAWSNeptuneCluster_updateIamRoles
=== PAUSE TestAccAWSNeptuneCluster_updateIamRoles
=== RUN   TestAccAWSNeptuneCluster_kmsKey
=== PAUSE TestAccAWSNeptuneCluster_kmsKey
=== RUN   TestAccAWSNeptuneCluster_encrypted
=== PAUSE TestAccAWSNeptuneCluster_encrypted
=== RUN   TestAccAWSNeptuneCluster_backupsUpdate
=== PAUSE TestAccAWSNeptuneCluster_backupsUpdate
=== RUN   TestAccAWSNeptuneCluster_iamAuth
=== PAUSE TestAccAWSNeptuneCluster_iamAuth
=== CONT  TestAccAWSNeptuneClusterInstance_basic
=== CONT  TestAccAWSNeptuneCluster_iamAuth
=== CONT  TestAccAWSNeptuneCluster_namePrefix
=== CONT  TestAccAWSNeptuneClusterInstance_withaz
=== CONT  TestAccAWSNeptuneClusterParameterGroup_generatedName
=== CONT  TestAccAWSNeptuneClusterInstance_kmsKey
=== CONT  TestAccAWSNeptuneCluster_backupsUpdate
=== CONT  TestAccAWSNeptuneCluster_encrypted
=== CONT  TestAccAWSNeptuneCluster_kmsKey
=== CONT  TestAccAWSNeptuneCluster_updateIamRoles
=== CONT  TestAccAWSNeptuneCluster_updateTags
=== CONT  TestAccAWSNeptuneCluster_takeFinalSnapshot
=== CONT  TestAccAWSNeptuneClusterInstance_generatedName
=== CONT  TestAccAWSNeptuneClusterInstance_withSubnetGroup
=== CONT  TestAccAWSNeptuneClusterParameterGroup_basic
=== CONT  TestAccAWSNeptuneClusterParameterGroup_Parameter
=== CONT  TestAccAWSNeptuneClusterParameterGroup_Description
=== CONT  TestAccAWSNeptuneClusterInstance_namePrefix
=== CONT  TestAccAWSNeptuneClusterSnapshot_basic
=== CONT  TestAccAWSNeptuneClusterParameterGroup_Tags
--- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (32.62s)
=== CONT  TestAccAWSNeptuneCluster_basic
--- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (32.89s)
=== CONT  TestAccAWSNeptuneClusterParameterGroup_namePrefix
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (33.80s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (52.07s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (29.14s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (75.15s)
--- PASS: TestAccAWSNeptuneCluster_updateTags (153.44s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (157.60s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (157.61s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (184.88s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (187.67s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (197.13s)
--- PASS: TestAccAWSNeptuneCluster_basic (165.54s)
--- PASS: TestAccAWSNeptuneClusterSnapshot_basic (217.99s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (220.53s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (224.89s)
--- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (765.18s)
--- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (798.26s)
--- PASS: TestAccAWSNeptuneClusterInstance_generatedName (810.45s)
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (834.49s)
--- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (859.23s)
--- PASS: TestAccAWSNeptuneClusterInstance_basic (1635.63s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws

make testacc TESTARGS="-run=TestAccAWSNeptuneClusterInstance"   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSNeptuneClusterInstance -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSNeptuneClusterInstance_basic
=== PAUSE TestAccAWSNeptuneClusterInstance_basic
=== RUN   TestAccAWSNeptuneClusterInstance_withaz
=== PAUSE TestAccAWSNeptuneClusterInstance_withaz
=== RUN   TestAccAWSNeptuneClusterInstance_namePrefix
=== PAUSE TestAccAWSNeptuneClusterInstance_namePrefix
=== RUN   TestAccAWSNeptuneClusterInstance_withSubnetGroup
=== PAUSE TestAccAWSNeptuneClusterInstance_withSubnetGroup
=== RUN   TestAccAWSNeptuneClusterInstance_generatedName
=== PAUSE TestAccAWSNeptuneClusterInstance_generatedName
=== RUN   TestAccAWSNeptuneClusterInstance_kmsKey
=== PAUSE TestAccAWSNeptuneClusterInstance_kmsKey
=== CONT  TestAccAWSNeptuneClusterInstance_basic
=== CONT  TestAccAWSNeptuneClusterInstance_generatedName
=== CONT  TestAccAWSNeptuneClusterInstance_withaz
=== CONT  TestAccAWSNeptuneClusterInstance_kmsKey
=== CONT  TestAccAWSNeptuneClusterInstance_withSubnetGroup
=== CONT  TestAccAWSNeptuneClusterInstance_namePrefix
--- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (752.92s)
--- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (755.13s)
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (786.51s)
--- PASS: TestAccAWSNeptuneClusterInstance_generatedName (806.21s)
--- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (875.11s)
--- PASS: TestAccAWSNeptuneClusterInstance_basic (1569.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1570.981s


make testacc TESTARGS="-run=TestAccAWSNeptuneParameterGroup" 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSNeptuneParameterGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSNeptuneParameterGroup_basic
=== PAUSE TestAccAWSNeptuneParameterGroup_basic
=== RUN   TestAccAWSNeptuneParameterGroup_Description
=== PAUSE TestAccAWSNeptuneParameterGroup_Description
=== RUN   TestAccAWSNeptuneParameterGroup_Parameter
=== PAUSE TestAccAWSNeptuneParameterGroup_Parameter
=== RUN   TestAccAWSNeptuneParameterGroup_Tags
=== PAUSE TestAccAWSNeptuneParameterGroup_Tags
=== CONT  TestAccAWSNeptuneParameterGroup_basic
=== CONT  TestAccAWSNeptuneParameterGroup_Tags
=== CONT  TestAccAWSNeptuneParameterGroup_Description
=== CONT  TestAccAWSNeptuneParameterGroup_Parameter
--- PASS: TestAccAWSNeptuneParameterGroup_basic (32.01s)
--- PASS: TestAccAWSNeptuneParameterGroup_Description (32.74s)
--- PASS: TestAccAWSNeptuneParameterGroup_Parameter (61.28s)
--- PASS: TestAccAWSNeptuneParameterGroup_Tags (74.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       76.611s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/neptune Issues and PRs that pertain to the neptune service. labels Jun 18, 2019
@ryndaniels ryndaniels requested a review from bflad June 18, 2019 09:48
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Jun 18, 2019
@bflad bflad self-assigned this Jun 18, 2019
bflad
bflad approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix, but otherwise LGTM 🚀

--- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (12.22s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (12.45s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (15.66s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (15.67s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (23.26s)
--- PASS: TestAccAWSNeptuneParameterGroup_Description (9.87s)
--- PASS: TestAccAWSNeptuneParameterGroup_basic (16.18s)
--- PASS: TestAccAWSNeptuneParameterGroup_Parameter (24.28s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (48.76s)
--- PASS: TestAccAWSNeptuneParameterGroup_Tags (29.97s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (115.01s)
--- PASS: TestAccAWSNeptuneCluster_basic (116.42s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (119.27s)
--- PASS: TestAccAWSNeptuneCluster_updateTags (119.95s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (135.47s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (143.37s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (139.46s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (148.77s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (175.69s)
--- PASS: TestAccAWSNeptuneClusterSnapshot_basic (205.67s)
--- PASS: TestAccAWSNeptuneClusterInstance_generatedName (665.56s)
--- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (705.75s)
--- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (725.64s)
--- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (803.47s)
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (810.30s)
--- PASS: TestAccAWSNeptuneClusterInstance_basic (1542.07s)

aws/resource_aws_neptune_parameter_group.go Show resolved Hide resolved
@bflad bflad added this to the v2.16.0 milestone Jun 18, 2019
@bflad bflad assigned ryndaniels and unassigned bflad Jun 18, 2019
@ryndaniels @bflad
Update aws/resource_aws_neptune_parameter_group.go
7aadb7e 
Co-Authored-By: Brian Flad <bflad417@gmail.com>
@ryndaniels ryndaniels merged commit ce46fb6 into master Jun 19, 2019
bflad added a commit that referenced this pull request Jun 20, 2019
@bflad
Update CHANGELOG for #8992, #9013, #9017, and #9036
e8664b4
@ryndaniels ryndaniels deleted the rfd-retry-neptune branch June 20, 2019 11:53
@bflad
Copy link
Contributor

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@ryndaniels ryndaniels

Labels
bug Addresses a defect in current functionality. service/neptune Issues and PRs that pertain to the neptune service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad