Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_apigatewayv2_integration_response #9365

Merged
merged 2 commits into from
Apr 14, 2020
Merged

New resource: aws_apigatewayv2_integration_response #9365

merged 2 commits into from
Apr 14, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 16, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_apigatewayv2_integration_response

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2IntegrationResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2IntegrationResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2IntegrationResponse_basic
=== PAUSE TestAccAWSAPIGateway2IntegrationResponse_basic
=== RUN   TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
=== PAUSE TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
=== CONT  TestAccAWSAPIGateway2IntegrationResponse_basic
=== CONT  TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
--- PASS: TestAccAWSAPIGateway2IntegrationResponse_basic (28.55s)
--- PASS: TestAccAWSAPIGateway2IntegrationResponse_AllAttributes (46.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.412s

Currently based on #8842, will need to rebase once that PR is merged.

@ewbankkit ewbankkit requested a review from a team July 16, 2019 18:06
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jul 16, 2019
@ewbankkit
Copy link
Contributor Author

Includes

@ewbankkit ewbankkit mentioned this pull request Jul 16, 2019
Closed
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration_response branch from bf2fe54 to ef15f3d Compare July 16, 2019 20:02
@ewbankkit ewbankkit changed the title [WIP] New resource: aws_api_gateway_v2_integration_response New resource: aws_api_gateway_v2_integration_response Jul 16, 2019
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration_response branch from 163eae5 to a64e7fa Compare July 26, 2019 20:25
@ewbankkit
Copy link
Contributor Author

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2IntegrationResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2IntegrationResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2IntegrationResponse_basic
=== PAUSE TestAccAWSAPIGateway2IntegrationResponse_basic
=== RUN   TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
=== PAUSE TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
=== CONT  TestAccAWSAPIGateway2IntegrationResponse_basic
=== CONT  TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
--- PASS: TestAccAWSAPIGateway2IntegrationResponse_basic (22.79s)
--- PASS: TestAccAWSAPIGateway2IntegrationResponse_AllAttributes (37.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.260s

@ewbankkit
Copy link
Contributor Author

Re-ran acceptance tests:

$  make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2IntegrationResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2IntegrationResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2IntegrationResponse_basic
=== PAUSE TestAccAWSAPIGateway2IntegrationResponse_basic
=== RUN   TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
=== PAUSE TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
=== CONT  TestAccAWSAPIGateway2IntegrationResponse_basic
=== CONT  TestAccAWSAPIGateway2IntegrationResponse_AllAttributes
--- PASS: TestAccAWSAPIGateway2IntegrationResponse_basic (22.84s)
--- PASS: TestAccAWSAPIGateway2IntegrationResponse_AllAttributes (35.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.795s

@ewbankkit
Copy link
Contributor Author

After merge of #8949, incorporate all the feedback:

  • Migrate to Terraform provider SDK
  • Change resource name to aws_apigatewayv2_blah; Rename source files
  • Remove sidebar_current from documentation
  • Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
  • Change function names to ApiGatewayV2
  • Add _disappears acceptance test
  • Use multierror in any test sweeper

@ewbankkit ewbankkit changed the title New resource: aws_api_gateway_v2_integration_response New resource: aws_api_gatewayv2_integration_response Apr 9, 2020
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration_response branch from 228a9eb to 1e17132 Compare April 9, 2020 18:31
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Apr 9, 2020
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration_response branch from 1e17132 to d4e10d7 Compare April 9, 2020 18:33
@ewbankkit
Copy link
Contributor Author

Renamed resource to aws_apigatewayv2_integration_response.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2IntegrationResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2IntegrationResponse_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2IntegrationResponse_basic
=== PAUSE TestAccAWSAPIGatewayV2IntegrationResponse_basic
=== RUN   TestAccAWSAPIGatewayV2IntegrationResponse_disappears
=== PAUSE TestAccAWSAPIGatewayV2IntegrationResponse_disappears
=== RUN   TestAccAWSAPIGatewayV2IntegrationResponse_AllAttributes
=== PAUSE TestAccAWSAPIGatewayV2IntegrationResponse_AllAttributes
=== CONT  TestAccAWSAPIGatewayV2IntegrationResponse_basic
=== CONT  TestAccAWSAPIGatewayV2IntegrationResponse_AllAttributes
=== CONT  TestAccAWSAPIGatewayV2IntegrationResponse_disappears
--- PASS: TestAccAWSAPIGatewayV2IntegrationResponse_disappears (24.87s)
--- PASS: TestAccAWSAPIGatewayV2IntegrationResponse_basic (28.41s)
--- PASS: TestAccAWSAPIGatewayV2IntegrationResponse_AllAttributes (45.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.098s

@ewbankkit
Copy link
Contributor Author

This is now ready for review.

gdavison
gdavison approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2IntegrationResponse_disappears (9.93s)
--- PASS: TestAccAWSAPIGatewayV2IntegrationResponse_basic (10.99s)
--- PASS: TestAccAWSAPIGatewayV2IntegrationResponse_AllAttributes (17.02s)

@gdavison gdavison merged commit 64ae497 into hashicorp:master Apr 14, 2020
gdavison added a commit that referenced this pull request Apr 14, 2020
@gdavison
Update CHANGELOG for #9365
91833d5
@ewbankkit ewbankkit changed the title New resource: aws_api_gatewayv2_integration_response New resource: aws_apigatewayv2_integration_response Apr 15, 2020
@ewbankkit ewbankkit deleted the issue-7004.aws_api_gateway_v2_integration_response branch April 15, 2020 10:38
@ewbankkit ewbankkit mentioned this pull request Apr 15, 2020
Merged
@ghost
Copy link

ghost commented May 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @gdavison