New resource: aws_apigatewayv2_integration #8949

ewbankkit · 2019-06-11T17:49:10Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_apigatewayv2_integration

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Integration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Integration_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Integration_basic
=== PAUSE TestAccAWSAPIGateway2Integration_basic
=== RUN   TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
=== PAUSE TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
=== RUN   TestAccAWSAPIGateway2Integration_Lambda
=== PAUSE TestAccAWSAPIGateway2Integration_Lambda
=== RUN   TestAccAWSAPIGateway2Integration_VpcLink
=== PAUSE TestAccAWSAPIGateway2Integration_VpcLink
=== CONT  TestAccAWSAPIGateway2Integration_basic
=== CONT  TestAccAWSAPIGateway2Integration_VpcLink
=== CONT  TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
=== CONT  TestAccAWSAPIGateway2Integration_Lambda
--- PASS: TestAccAWSAPIGateway2Integration_basic (23.83s)
--- PASS: TestAccAWSAPIGateway2Integration_IntegrationTypeHttp (39.78s)
--- PASS: TestAccAWSAPIGateway2Integration_Lambda (41.64s)
--- PASS: TestAccAWSAPIGateway2Integration_VpcLink (708.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	709.004s

~~Currently based on #8842, will need to rebase once that PR is merged.~~

ewbankkit · 2019-07-01T17:06:03Z

Rebased to track #8842 (comment).

ewbankkit · 2019-07-26T20:11:32Z

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Integration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Integration_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Integration_basic
=== PAUSE TestAccAWSAPIGateway2Integration_basic
=== RUN   TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
=== PAUSE TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
=== RUN   TestAccAWSAPIGateway2Integration_Lambda
=== PAUSE TestAccAWSAPIGateway2Integration_Lambda
=== RUN   TestAccAWSAPIGateway2Integration_VpcLink
=== PAUSE TestAccAWSAPIGateway2Integration_VpcLink
=== CONT  TestAccAWSAPIGateway2Integration_basic
=== CONT  TestAccAWSAPIGateway2Integration_VpcLink
=== CONT  TestAccAWSAPIGateway2Integration_Lambda
=== CONT  TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
--- PASS: TestAccAWSAPIGateway2Integration_basic (21.63s)
--- PASS: TestAccAWSAPIGateway2Integration_IntegrationTypeHttp (34.45s)
--- PASS: TestAccAWSAPIGateway2Integration_Lambda (38.25s)
--- PASS: TestAccAWSAPIGateway2Integration_VpcLink (722.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	722.386s

ewbankkit · 2019-08-16T17:52:44Z

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Integration_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Integration_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Integration_basic
=== PAUSE TestAccAWSAPIGateway2Integration_basic
=== RUN   TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
=== PAUSE TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
=== RUN   TestAccAWSAPIGateway2Integration_Lambda
=== PAUSE TestAccAWSAPIGateway2Integration_Lambda
=== RUN   TestAccAWSAPIGateway2Integration_VpcLink
=== PAUSE TestAccAWSAPIGateway2Integration_VpcLink
=== CONT  TestAccAWSAPIGateway2Integration_basic
=== CONT  TestAccAWSAPIGateway2Integration_VpcLink
=== CONT  TestAccAWSAPIGateway2Integration_Lambda
=== CONT  TestAccAWSAPIGateway2Integration_IntegrationTypeHttp
--- PASS: TestAccAWSAPIGateway2Integration_basic (22.25s)
--- PASS: TestAccAWSAPIGateway2Integration_IntegrationTypeHttp (34.91s)
--- PASS: TestAccAWSAPIGateway2Integration_Lambda (38.44s)
--- PASS: TestAccAWSAPIGateway2Integration_VpcLink (734.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	734.131s

ewbankkit · 2020-03-13T12:51:08Z

After merge of #8842, incorporate all the feedback:

Migrate to Terraform provider SDK
Change resource name to aws_apigatewayv2_blah; Rename source files
Remove sidebar_current from documentation
Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
Change function names to ApiGatewayV2
Add _disappears acceptance test
Use multierror in any test sweeper

ewbankkit · 2020-03-13T15:26:11Z

Renamed resource to aws_apigatewayv2_integration.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Integration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Integration_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Integration_basic
=== PAUSE TestAccAWSAPIGatewayV2Integration_basic
=== RUN   TestAccAWSAPIGatewayV2Integration_disappears
=== PAUSE TestAccAWSAPIGatewayV2Integration_disappears
=== RUN   TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== RUN   TestAccAWSAPIGatewayV2Integration_Lambda
=== PAUSE TestAccAWSAPIGatewayV2Integration_Lambda
=== RUN   TestAccAWSAPIGatewayV2Integration_VpcLink
=== PAUSE TestAccAWSAPIGatewayV2Integration_VpcLink
=== CONT  TestAccAWSAPIGatewayV2Integration_basic
=== CONT  TestAccAWSAPIGatewayV2Integration_Lambda
=== CONT  TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== CONT  TestAccAWSAPIGatewayV2Integration_disappears
=== CONT  TestAccAWSAPIGatewayV2Integration_VpcLink
--- PASS: TestAccAWSAPIGatewayV2Integration_disappears (23.85s)
--- PASS: TestAccAWSAPIGatewayV2Integration_basic (27.84s)
--- PASS: TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp (43.88s)
--- PASS: TestAccAWSAPIGatewayV2Integration_Lambda (52.86s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLink (657.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	657.827s

ewbankkit · 2020-03-16T22:23:15Z

This is now ready for review.

aws/resource_aws_apigatewayv2_integration_test.go

…grations.

…_config' attributes.

ewbankkit · 2020-03-24T21:53:05Z

Rebased after merge of #12400.

Re-ran affected acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Integration_VpcLink'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Integration_VpcLink -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Integration_VpcLink
=== PAUSE TestAccAWSAPIGatewayV2Integration_VpcLink
=== CONT  TestAccAWSAPIGatewayV2Integration_VpcLink
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLink (698.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	698.227s

ewbankkit · 2020-03-26T18:10:34Z

I will add a new aws_apigatewayv2_vpc_link as a separate PR and include additional aws_apigatewayv2_integration acceptance tests for private integrations for HTTP APIs then.

gdavison

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2Integration_disappears (10.11s)
--- PASS: TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp (16.91s)
--- PASS: TestAccAWSAPIGatewayV2Integration_basic (28.73s)
--- PASS: TestAccAWSAPIGatewayV2Integration_Lambda (34.52s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLink (657.35s)

ghost · 2020-04-10T00:37:53Z

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-05-09T17:10:13Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

This was referenced Jun 11, 2019

New resource: aws_apigatewayv2_route #8881

Merged

API Gateway- Websocket #7004

Closed

aeschright requested a review from a team June 28, 2019 18:13

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from 8b4e87b to 47051ec Compare July 1, 2019 17:05

ghost added the service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. label Jul 1, 2019

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from 47051ec to ea8964b Compare July 1, 2019 19:15

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 1, 2019

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch 2 times, most recently from 12cc8b9 to b467ff4 Compare July 2, 2019 17:08

ewbankkit changed the title ~~[WIP] New resource: aws_api_gateway_v2_integration~~ New resource: aws_api_gateway_v2_integration Jul 2, 2019

ewbankkit mentioned this pull request Jul 16, 2019

New resource: aws_apigatewayv2_integration_response #9365

Merged

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from b467ff4 to ba2a6a1 Compare July 26, 2019 20:11

aeschright added the new-resource Introduces a new resource. label Aug 19, 2019

ewbankkit changed the title ~~New resource: aws_api_gateway_v2_integration~~ New resource: aws_apigatewayv2_integration Mar 13, 2020

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from 1dac073 to 16168dd Compare March 13, 2020 14:27

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 13, 2020

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from 16168dd to 04312b8 Compare March 13, 2020 14:32

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from 3bd0388 to 7c2c09b Compare March 13, 2020 15:48

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from 7c2c09b to bd6a4f0 Compare March 13, 2020 20:59

ewbankkit mentioned this pull request Mar 14, 2020

Amazon API Gateway HTTP APIs #11148

Closed

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from c2b18c5 to 96b7e85 Compare March 16, 2020 22:20

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from 96b7e85 to cba8251 Compare March 19, 2020 17:19

gdavison reviewed Mar 24, 2020

View reviewed changes

aws/resource_aws_apigatewayv2_integration_test.go Outdated Show resolved Hide resolved

Kit Ewbank and others added 5 commits March 24, 2020 17:16

Add 'aws_api_gateway_v2_integration' resource.

563ed4d

'aws_api_gateway2_integration' -> 'aws_apigatewayv2_integration'.

ad89102

r/aws_apigatewayv2_integration: Don't import API Gateway managed inte…

a9ee64c

…grations.

r/aws_apigatewayv2_integration: Add 'payload_format_version' and 'tls…

ac97c9d

…_config' attributes.

Remove 'tls_config' attribute. It doesn't seem to do anything right now.

ffbce32

gdavison self-assigned this Mar 24, 2020

Use availability zone filter (hashicorp#12400 merged).

0c754c5

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_integration branch from cba8251 to 0c754c5 Compare March 24, 2020 21:51

gdavison approved these changes Apr 7, 2020

View reviewed changes

gdavison added this to the v2.57.0 milestone Apr 7, 2020

Merge branch 'master' into issue-7004.aws_api_gateway_v2_integration

6a4815b

gdavison merged commit a5a8275 into hashicorp:master Apr 8, 2020

gdavison added a commit that referenced this pull request Apr 8, 2020

Update CHANGELOG for #8949

45fe2ed

j-nix mentioned this pull request Apr 9, 2020

Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162

Merged

ewbankkit deleted the issue-7004.aws_api_gateway_v2_integration branch April 9, 2020 10:04

ewbankkit mentioned this pull request Apr 9, 2020

Fix missing side navigation links: aws_apigatewayv2_integration and aws_apigatewayv2_model #12746

Merged

This was referenced Apr 22, 2020

New data source: aws_apigatewayv2_integration #12956

Closed

Allow tls_config attribute on aws_apigatewayv2_integration resource #12971

Closed

ghost locked and limited conversation to collaborators May 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_apigatewayv2_integration #8949

New resource: aws_apigatewayv2_integration #8949

ewbankkit commented Jun 11, 2019 •

edited

Loading

ewbankkit commented Jul 1, 2019

ewbankkit commented Jul 26, 2019 •

edited

Loading

ewbankkit commented Aug 16, 2019

ewbankkit commented Mar 13, 2020 •

edited

Loading

ewbankkit commented Mar 13, 2020

ewbankkit commented Mar 16, 2020

ewbankkit commented Mar 24, 2020

ewbankkit commented Mar 26, 2020

gdavison left a comment

ghost commented Apr 10, 2020

ghost commented May 9, 2020

New resource: aws_apigatewayv2_integration #8949

New resource: aws_apigatewayv2_integration #8949

Conversation

ewbankkit commented Jun 11, 2019 • edited Loading

Community Note

ewbankkit commented Jul 1, 2019

ewbankkit commented Jul 26, 2019 • edited Loading

ewbankkit commented Aug 16, 2019

ewbankkit commented Mar 13, 2020 • edited Loading

ewbankkit commented Mar 13, 2020

ewbankkit commented Mar 16, 2020

ewbankkit commented Mar 24, 2020

ewbankkit commented Mar 26, 2020

gdavison left a comment

Choose a reason for hiding this comment

ghost commented Apr 10, 2020

ghost commented May 9, 2020

ewbankkit commented Jun 11, 2019 •

edited

Loading

ewbankkit commented Jul 26, 2019 •

edited

Loading

ewbankkit commented Mar 13, 2020 •

edited

Loading