service/ec2: Initial support for Local Zones #12400

bflad · 2020-03-15T23:52:39Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11136
Reference: #11994

Release note for CHANGELOG:

FEATURES:

* **New Resource:** `aws_ec2_availability_zone_group`

ENHANCEMENTS:

* data-source/aws_availability_zone: Add `all_availability_zones` and `filter` arguments
* data-source/aws_availability_zone: Add `group_name`, `network_border_group`, and `opt_in_status` attributes
* data-source/aws_availability_zones: Add `all_availability_zones` and `filter` arguments
* data-source/aws_availability_zones: Add `group_names` attribute

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (17.53s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (17.74s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (17.74s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (17.79s)

--- PASS: TestAccAWSAvailabilityZones_Filter (15.46s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (15.87s)
--- PASS: TestAccAWSAvailabilityZones_basic (16.60s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (16.70s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (17.00s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (17.14s)

--- PASS: TestAccAWSEc2AvailabilityZoneGroup_OptInStatus (37.67s)

Reference: #11136 Reference: #11994 Changes: * New Resource: `aws_ec2_availability_zone_group` * data-source/aws_availability_zone: Add `all_availability_zones` and `filter` arguments * data-source/aws_availability_zone: Add `group_name`, `network_border_group`, and `opt_in_status` attributes * data-source/aws_availability_zones: Add `all_availability_zones` and `filter` arguments * data-source/aws_availability_zones: Add `group_names` attribute ``` --- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (17.53s) --- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (17.74s) --- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (17.74s) --- PASS: TestAccDataSourceAwsAvailabilityZone_Name (17.79s) --- PASS: TestAccAWSAvailabilityZones_Filter (15.46s) --- PASS: TestAccAWSAvailabilityZones_stateFilter (15.87s) --- PASS: TestAccAWSAvailabilityZones_basic (16.60s) --- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (16.70s) --- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (17.00s) --- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (17.14s) --- PASS: TestAccAWSEc2AvailabilityZoneGroup_OptInStatus (37.67s) ```

ewbankkit · 2020-03-16T12:12:49Z

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone_ -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== PAUSE TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== RUN   TestAccDataSourceAwsAvailabilityZone_Filter
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Filter
=== RUN   TestAccDataSourceAwsAvailabilityZone_Name
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Name
=== RUN   TestAccDataSourceAwsAvailabilityZone_ZoneId
=== PAUSE TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== CONT  TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_Filter
=== CONT  TestAccDataSourceAwsAvailabilityZone_Name
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (25.64s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (25.83s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (25.99s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (26.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.064s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAvailabilityZones_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAvailabilityZones_ -timeout 120m
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_AllAvailabilityZones
=== PAUSE TestAccAWSAvailabilityZones_AllAvailabilityZones
=== RUN   TestAccAWSAvailabilityZones_BlacklistedNames
=== PAUSE TestAccAWSAvailabilityZones_BlacklistedNames
=== RUN   TestAccAWSAvailabilityZones_BlacklistedZoneIds
=== PAUSE TestAccAWSAvailabilityZones_BlacklistedZoneIds
=== RUN   TestAccAWSAvailabilityZones_Filter
=== PAUSE TestAccAWSAvailabilityZones_Filter
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccAWSAvailabilityZones_Filter
=== CONT  TestAccAWSAvailabilityZones_BlacklistedZoneIds
=== CONT  TestAccAWSAvailabilityZones_BlacklistedNames
=== CONT  TestAccAWSAvailabilityZones_AllAvailabilityZones
=== CONT  TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (23.45s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (24.19s)
--- PASS: TestAccAWSAvailabilityZones_basic (24.20s)
--- PASS: TestAccAWSAvailabilityZones_Filter (24.25s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (25.19s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (25.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.014s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2AvailabilityZoneGroup_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSEc2AvailabilityZoneGroup_ -timeout 120m
=== RUN   TestAccAWSEc2AvailabilityZoneGroup_OptInStatus
=== PAUSE TestAccAWSEc2AvailabilityZoneGroup_OptInStatus
=== CONT  TestAccAWSEc2AvailabilityZoneGroup_OptInStatus
--- PASS: TestAccAWSEc2AvailabilityZoneGroup_OptInStatus (41.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.390s

gdavison

Aside from the documentation questions, LGTM 🚀

--- PASS: TestAvailabilityZonesSort (0.00s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (9.32s)
--- PASS: TestAccAWSAvailabilityZones_basic (9.61s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (9.87s)
--- PASS: TestAccAWSAvailabilityZones_Filter (9.85s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (10.28s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (10.30s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (10.50s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (10.56s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (10.54s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (10.65s)
--- PASS: TestAccAWSEc2AvailabilityZoneGroup_OptInStatus (92.96s)

website/docs/d/availability_zones.html.markdown

gdavison · 2020-03-23T18:04:33Z

website/docs/r/ec2_availability_zone_group.html.markdown

+
+Manages an EC2 Availability Zone Group, such as updating its opt-in status.
+
+~> **NOTE:** This is an advanced Terraform resource. Terraform will automatically assume management of the EC2 Availability Zone Group without import and perform no actions on removal from configuration.


Should we add a note about needing to contact AWS Support to disable a Local Zone?

…nly no Local Zones Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/12400/files#r396627794

gdavison · 2020-03-24T19:34:39Z

website/docs/d/availability_zone.html.markdown

 * `name` - (Optional) The full name of the availability zone to select.
+* `state` - (Optional) A specific availability zone state to require. May be any of `"available"`, `"information"` or `"impaired"`.


unavailable is also an available option 😉

… top regarding Local Zones behavior Reference: #12400 (comment)

ghost · 2020-03-27T22:03:30Z

This has been released in version 2.55.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-04-24T17:10:37Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

bflad added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. labels Mar 15, 2020

bflad requested a review from a team March 15, 2020 23:52

bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 15, 2020

bflad mentioned this pull request Mar 15, 2020

Initial support for Local Zones #11136

Closed

bflad mentioned this pull request Mar 16, 2020

Disable Local Zones in Acceptance Testing Configurations #12412

Closed

paultyng approved these changes Mar 16, 2020

View reviewed changes

ewbankkit mentioned this pull request Mar 17, 2020

Add 'filter' block to EC2 service data source that are currently missing this #11994

Closed

7 tasks

gdavison approved these changes Mar 23, 2020

View reviewed changes

gdavison mentioned this pull request Mar 24, 2020

Fixes Elastic Beanstalk Application and Environment Sweepers and Tests #12511

Merged

docs/data-source/aws_availability_zones: Additional example showing o…

6a7714f

…nly no Local Zones Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/12400/files#r396627794

gdavison reviewed Mar 24, 2020

View reviewed changes

docs/data-source/aws_availability_zones: Add informational box at the…

e9a5e61

… top regarding Local Zones behavior Reference: #12400 (comment)

bflad added this to the v2.55.0 milestone Mar 24, 2020

bflad merged commit cb72b1f into master Mar 24, 2020

bflad deleted the f-ec2-local-zone-support branch March 24, 2020 20:04

bflad added a commit that referenced this pull request Mar 24, 2020

Update CHANGELOG for #12400

81c55de

ewbankkit added a commit to ewbankkit/terraform-provider-aws that referenced this pull request Mar 24, 2020

Use availability zone filter (hashicorp#12400 merged).

0c754c5

ewbankkit mentioned this pull request Mar 24, 2020

New resource: aws_apigatewayv2_integration #8949

Merged

ghost locked and limited conversation to collaborators Apr 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

service/ec2: Initial support for Local Zones #12400

service/ec2: Initial support for Local Zones #12400

bflad commented Mar 15, 2020

ewbankkit commented Mar 16, 2020

gdavison left a comment

gdavison Mar 23, 2020

gdavison Mar 24, 2020 •

edited

Loading

ghost commented Mar 27, 2020

ghost commented Apr 24, 2020


		Manages an EC2 Availability Zone Group, such as updating its opt-in status.

		~> NOTE: This is an advanced Terraform resource. Terraform will automatically assume management of the EC2 Availability Zone Group without import and perform no actions on removal from configuration.

		* `name` - (Optional) The full name of the availability zone to select.
		* `state` - (Optional) A specific availability zone state to require. May be any of `"available"`, `"information"` or `"impaired"`.

service/ec2: Initial support for Local Zones #12400

service/ec2: Initial support for Local Zones #12400

Conversation

bflad commented Mar 15, 2020

Community Note

ewbankkit commented Mar 16, 2020

gdavison left a comment

Choose a reason for hiding this comment

gdavison Mar 23, 2020

Choose a reason for hiding this comment

gdavison Mar 24, 2020 • edited Loading

Choose a reason for hiding this comment

ghost commented Mar 27, 2020

ghost commented Apr 24, 2020

gdavison Mar 24, 2020 •

edited

Loading