Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS IoT Rule Action to send data to an AWS IoT Events input #9890

Merged
merged 4 commits into from
May 12, 2020

Conversation

ktarasz
Copy link
Contributor

@ktarasz ktarasz commented Aug 27, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9889

Release note for CHANGELOG:

Add AWS IoT Rule Action to send data to an AWS IoT Events input

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSIoTTopicRule_iot_events'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSIoTTopicRule_iot_events -timeout 120m
=== RUN   TestAccAWSIoTTopicRule_iot_events
=== PAUSE TestAccAWSIoTTopicRule_iot_events
=== CONT  TestAccAWSIoTTopicRule_iot_events
--- PASS: TestAccAWSIoTTopicRule_iot_events (38.20s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       38.236s

@ktarasz ktarasz requested a review from a team August 27, 2019 10:03
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 27, 2019
@ktarasz ktarasz changed the title Add iot events action Add support for AWS IoT Rule Action to send data to an AWS IoT Events input Aug 27, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label May 12, 2020
@bflad bflad added this to the v2.62.0 milestone May 12, 2020
@bflad bflad self-assigned this May 12, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ktarasz 👋 Thank you for working on this and apologies for the delays getting it reviewed. We will be merging #7469, #9859, #9890, and #12714 at the same time to handle all the merge conflicts. 👍

@bflad bflad merged commit beea1f8 into hashicorp:master May 12, 2020
bflad added a commit that referenced this pull request May 12, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AWS IoT Rule Action to send data to an AWS IoT Events input
3 participants