Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azuread_client_config #229

Merged
merged 6 commits into from
Mar 12, 2020
Merged

New Data Source: azuread_client_config #229

merged 6 commits into from
Mar 12, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Mar 12, 2020

fixes #214

@katbyte katbyte added this to the v0.8.0 milestone Mar 12, 2020
@ghost ghost added the size/M label Mar 12, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need docs for this?

@katbyte
Copy link
Collaborator Author

katbyte commented Mar 12, 2020

yes 🤦‍♀

@ghost ghost added size/L documentation and removed size/M labels Mar 12, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte merged commit 7008a97 into master Mar 12, 2020
@katbyte katbyte deleted the kt/client-config branch March 12, 2020 22:44
katbyte added a commit that referenced this pull request Mar 12, 2020
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
@ghost
Copy link

ghost commented May 14, 2020

This has been released in version 0.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.8.0"
}
# ... other configuration ...

@ghost ghost unlocked this conversation May 14, 2020
@ghost ghost locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a data lookup for current client: azuread_client_config
2 participants