Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a few additional users attributes #597

Merged

Conversation

michaljirman
Copy link
Contributor

Add support for a few additional users attributes:

  • employeeType
  • costCenter
  • division

Depends on Hamilton update:
PR

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michaljirman, thanks for this PR! Overall this looks good, I have a few suggestions inline below on the field handling in the Create/Update funcs, and also some of the ordering in the schema and docs (the linter also picked up on one of these). If we can fix these up, this should be good to merge!

internal/services/users/user_data_source.go Outdated Show resolved Hide resolved
internal/services/users/user_data_source.go Show resolved Hide resolved
docs/data-sources/user.md Outdated Show resolved Hide resolved
docs/resources/user.md Outdated Show resolved Hide resolved
internal/services/users/user_resource.go Outdated Show resolved Hide resolved
internal/services/users/user_resource.go Outdated Show resolved Hide resolved
internal/services/users/user_resource.go Outdated Show resolved Hide resolved
internal/services/users/user_resource_test.go Outdated Show resolved Hide resolved
@michaljirman
Copy link
Contributor Author

Hi @michaljirman, thanks for this PR! Overall this looks good, I have a few suggestions inline below on the field handling in the Create/Update funcs, and also some of the ordering in the schema and docs (the linter also picked up on one of these). If we can fix these up, this should be good to merge!

Thanks a lot for the review! I have pushed the code changes based on the code review.
Considering this is my first contribution to the official version of this provider, please kindly review it thoroughly. It is more likely I have missed more things than it is common for the other contributors ;-)

Thanks!

@manicminer
Copy link
Contributor

@michaljirman Thanks for making the changes! This mostly LGTM, I had to make a small fix upstream for the EmployeeType field which is nullable (doesn't accept blank strings). Once manicminer/hamilton#110 and then #608 are merged, this should also be good to merge 👍

@manicminer manicminer self-assigned this Sep 30, 2021
@manicminer
Copy link
Contributor

Test results

Screenshot 2021-09-30 at 21 32 22

@manicminer manicminer merged commit ebb686b into hashicorp:main Sep 30, 2021
manicminer added a commit that referenced this pull request Sep 30, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants