-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a few additional users attributes #597
Add support for a few additional users attributes #597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michaljirman, thanks for this PR! Overall this looks good, I have a few suggestions inline below on the field handling in the Create/Update funcs, and also some of the ordering in the schema and docs (the linter also picked up on one of these). If we can fix these up, this should be good to merge!
Thanks a lot for the review! I have pushed the code changes based on the code review. Thanks! |
@michaljirman Thanks for making the changes! This mostly LGTM, I had to make a small fix upstream for the |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add support for a few additional users attributes:
Depends on Hamilton update:
PR