Support app_command_line in App Service site_config

[nickstenning]

I took a look at fixing #2349 myself and this is my first draft! Happy to change things if I've misunderstood anything :)

--

App Service supports setting a command line to use with Linux applications (e.g. to override the default in the container image). Expose this configuration as app_command_line in site_config for azurerm_app_service.

N.B. This is also referred to as "startup file" by some sources, including the az Azure CLI and the Azure Portal.

References:

• https://docs.microsoft.com/en-us/rest/api/appservice/webapps/createorupdate#siteconfig
• https://docs.microsoft.com/en-us/cli/azure/webapp?view=azure-cli-latest#az-webapp-create

--

Closes #2349.

[nickstenning]

Hmm. I've noticed that the test I added in azurerm/resource_arm_app_service_test.go doesn't actually appear to be running. If I change the assertion on line 221 the test suite still passes. 😕

This doesn't seem to be unique to my test (TestAccAzureRMAppService_appCommandLine). I can make changes that should break to, e.g., TestAccAzureRMAppService_linuxFxVersion and the suite still passes. Iiiiinteresting.

I've got to run right now but I'll look into this a bit more later on.

[nickstenning]

Oh, oops! I've realised that the reason the tests weren't running was because these aren't unit tests, they're acceptance tests. Ignore my previous comment 😄

[tombuildsstuff]

hey @nickstenning

Thanks for this PR :)

I've taken a look through and left a couple of comments inline - if we can add the test/documentation for App Service Slot this otherwise LGTM 👍

Thanks!

[nickstenning]

Thanks for the speedy review. Updated with the changes you requested.

[nickstenning]

Looks like Travis just stalled and needs a kick.

[katbyte]

Hi @nickstenning and @tombuildsstuff,

There currently is a PR open to a ton of the site config options to app service (#2138). It is ready to go outside of tests, however it doesn't seem like it includes app_command_line so we may want to coordinate with that PR.

[nickstenning]

Thanks, @katbyte 👍. It looks like function apps also accept the --startup-file option in their config [1], which I'm assuming is backed by the same part of SiteConfig.

If this merges first, the author of that PR may want update it to include the app_command_line option. If that PR merges first, I'm happy to update this one to expose app_command_line for azurerm_function_app. Either way. 😄

1. https://docs.microsoft.com/en-us/cli/azure/functionapp/config?view=azure-cli-latest

[tombuildsstuff]

LGTM - thanks for pushing those changes @nickstenning 👍

[tombuildsstuff]

Tests pass, ignoring a transient failure:

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!