Add forward_to property to servicebus subscription resource #861
Conversation
katbyte
changed the title
| @@ -98,6 +98,9 @@ The following arguments are supported: | |||
| supports the concept of a session. Defaults to false. Changing this forces a | |||
| new resource to be created. | |||
|
|
|||
| * `forward_to` - (Optional) The name of a Queue or Topic to automatically forward | |||
| messages to. Defaults to none. | |||
There was a problem hiding this comment.
We can remove the Defaults to none section here
| "forward_to": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "The name of a Queue or Topic to automatically forward messages to.", |
There was a problem hiding this comment.
as discussed on Slack, we don't generally specify the description for schema fields in the Azure Provider - we may in the future when there's a value for it (but there's no harm in leaving this in 😄)
| } | ||
|
|
||
|
|
||
| `, rInt, location, rInt, rInt, rInt, rInt) | ||
| } |
There was a problem hiding this comment.
can we make a specific test for forward to, since it's an optional field? we tend to use _basic to signify only the required fields
|
Tests passed.
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Adds forward_to property to servicebus subscription resource & fixes #810.