Add support node config for GKE node pool #184
Conversation
|
Looking forward to this getting merged. |
There was a problem hiding this comment.
Thanks for this @aadidenko! It mostly looks good to merge, just a few quick comments.
| @@ -85,6 +87,34 @@ func resourceContainerNodePoolCreate(d *schema.ResourceData, meta interface{}) e | |||
| InitialNodeCount: int64(nodeCount), | |||
| } | |||
|
|
|||
| if v, ok := d.GetOk("node_config"); ok { | |||
| nodeConfigs := v.([]interface{}) | |||
| if len(nodeConfigs) > 1 { | |||
There was a problem hiding this comment.
Instead of this check, let's set MaxItems: 1 in the schema itself (and then we can get rid of this check in resource_container_cluster.go too)
|
|
||
| nodePool.Config.OauthScopes = scopes | ||
| } | ||
| } |
There was a problem hiding this comment.
What about the other fields? (local_ssd_count, service_account, metadata, image_type, labels, tags)
| } | ||
| }`, acctest.RandString(10), acctest.RandString(10)) | ||
|
|
||
| func nodepoolCheckMatch(attributes map[string]string, attr string, gcp interface{}) string { |
There was a problem hiding this comment.
nit: typically we put helpers like this above the resource test vars
Looks good, thanks! I can merge this once the conflicts are resolved :) |
- Set max items in node config schema - Fill missing node config fields - Put test helpers above than test vars
aadidenko
force-pushed
the
gke-nodepool-node-config
branch
from
7a34f6b to
c1236a3
Compare
* Add support node config for GKE node pool * Review fixes: - Set max items in node config schema - Fill missing node config fields - Put test helpers above than test vars * Update checks in node pool tests * Fix node pool check match
* Add support node config for GKE node pool * Review fixes: - Set max items in node config schema - Fill missing node config fields - Put test helpers above than test vars * Update checks in node pool tests * Fix node pool check match
* Add support node config for GKE node pool * Review fixes: - Set max items in node config schema - Fill missing node config fields - Put test helpers above than test vars * Update checks in node pool tests * Fix node pool check match
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.