Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scopes, labels and tags on GKE Node Pool #161

Closed
stonith opened this issue Jun 28, 2017 · 5 comments
Closed

Add support for scopes, labels and tags on GKE Node Pool #161

stonith opened this issue Jun 28, 2017 · 5 comments
Assignees

Comments

@stonith
Copy link

stonith commented Jun 28, 2017

Terraform Version

Terraform v0.10.0-dev (9706042ddd51b85a46e23356536a1d812efa5a38+CHANGES)

Affected Resource(s)

google_container_node_pool

References

https://cloud.google.com/container-engine/docs/node-pools#creating_a_node_pool
https://cloud.google.com/sdk/gcloud/reference/beta/container/node-pools/create

Already added to google_container_cluster in #7

@stonith stonith changed the title Add support for labels and tags on GKE Node Pool Add support for scopes, labels and tags on GKE Node Pool Jun 28, 2017
@holoGDM
Copy link

holoGDM commented Jul 10, 2017

Hello, any progress with it?

@selmanj
Copy link
Contributor

selmanj commented Jul 10, 2017

I'm working on adding labels support currently; will relate PR when it's ready.

@selmanj selmanj self-assigned this Jul 10, 2017
@holoGDM
Copy link

holoGDM commented Aug 7, 2017

Hello again, is there some time in which i can expect it? I see there is new version of Terraform but this ticket is still not finished (same options for cluster creation ware implemented in next version from raising ticket). Just asking, because this options will be really helpfull (without it i can't fully finished our automation) for our config.

@selmanj
Copy link
Contributor

selmanj commented Aug 7, 2017

Actually this was added in #184 and should be available next release.

@selmanj selmanj closed this as completed Aug 7, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @cornmander
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @cornmander
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants