Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for labels and tags on GKE node_config #7

Merged
merged 2 commits into from
Jun 19, 2017

Conversation

unguiculus
Copy link
Contributor

No description provided.

@danawillow
Copy link
Contributor

Looks good! Mind updating the docs too? https://github.com/terraform-providers/terraform-provider-google/blob/master/website/docs/r/container_cluster.html.markdown

TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_withNodeConfig -timeout 120m
=== RUN   TestAccContainerCluster_withNodeConfig
--- PASS: TestAccContainerCluster_withNodeConfig (296.10s)
TF_ACC=1 go test ./google -v -run=TestAccContainerCluster_basic -timeout 120m
=== RUN   TestAccContainerCluster_basic
--- PASS: TestAccContainerCluster_basic (265.57s)
PASS

@unguiculus
Copy link
Contributor Author

@danawillow Updated docs.

@danawillow
Copy link
Contributor

LGTM, thanks @unguiculus!

@danawillow danawillow merged commit dcb564b into hashicorp:master Jun 19, 2017
pdecat pushed a commit to pdecat/terraform-provider-google that referenced this pull request Jun 29, 2017
Add support for labels and tags on GKE node_config
chrisst referenced this pull request in chrisst/terraform-provider-google Nov 9, 2018
Add support for labels and tags on GKE node_config
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants