Make removals in google_container_cluster #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
suggested changes
Nov 2, 2018
modular-magician
force-pushed
the
codegen-pr-674
branch
from
23a0217 to
f1fb6c9
Compare
danawillow
approved these changes
Nov 3, 2018
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ BACKWARDS INCOMPATIBILITIES: | |||
| * compute: `google_compute_instance`, `google_compute_instance_from_template` `metadata` field is now authoritative and will remove values not explicitly set in config. [GH-2208] | |||
| * compute: `google_compute_project_metadata` resource is now authoritative and will remove values not explicitly set in config. [GH-2205] | |||
| * compute: `google_compute_url_map` resource is now authoritative and will remove values not explicitly set in config. [GH-2245] | |||
| * compute: `google_compute_global_forwarding_rule.labels` is removed from the `google` provider and must be used in the `google-beta` provider. [GH-2399] | |||
There was a problem hiding this comment.
Huh! That was weird. I expect it was a race condition between the Magician doing merge-prs and my changes to the changelog? Looks like another run clobbered it.
modular-magician
force-pushed
the
codegen-pr-674
branch
from
f1fb6c9 to
b2e7c11
Compare
nat-henderson
pushed a commit
that referenced
this pull request
Dec 21, 2018
nat-henderson
pushed a commit
that referenced
this pull request
Dec 21, 2018
pdecat
added a commit
to pdecat/magic-modules
that referenced
this pull request
Feb 14, 2019
`private_cluster` and `master_ipv4_cidr_block` were not moved to google-beta but replaced by new fields. hashicorp/terraform-provider-google#2395 GA since 2018/10/02: https://cloud.google.com/kubernetes-engine/release-notes#october-2-2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @rileykarson