Splitting TerraFX.Interop.Windows into several projects #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngmarBitter
pushed a commit
to IngmarBitter/terrafx.interop.windows
that referenced
this pull request
May 24, 2020
Splitting TerraFX.Interop.Windows into several projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the single interop assembly into multiple, basically one per corresponding native library. Most shared bits are staying in TerraFX.Interop.Windows and some DirectX specific bits have been moved into D3DCommon and DCommon assemblies.
WinCodec and DWrite are normally circularly dependent with D2D1. This circle was broken by having WinCodec and DWrite just take IntPtr in the few places (less than 6) they were dependent on D2D1. D2D1 has a full dependency on WinCodec and DWrite, since that is less trivial to decouple.