[BUG] Add coml2api.h #267
Merged
[BUG] Add coml2api.h #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds all of the Structured Stroage (IStorage) related APIs and related defines. Add the remap-classes.rsp to the solution file. fixes terrafx#263 fixes terrafx#227
|
|
|
LGTM minus the suggested fix of explicitly listing library paths per method |
|
@tannergooding did you want things marked with set last error where appropriate? Wasn't sure given our offline discussion. |
Generally yes as I still document it in source via a trimmable attribute. My tool didn't flag any of this as required SetLastError though. |
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
tannergooding
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all of the Structured Stroage (IStorage) related APIs and related defines.
Add the remap-classes.rsp to the solution file.
fixes #263
fixes #227