Regenerating bindings to take advantage of some C# 11 features #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickbrew
reviewed
Jun 13, 2022
| [Guid("00000000-0000-0000-0000-000000000000")] | ||
| public partial struct ID3D11On12On7 | ||
| { | ||
| static ref readonly Guid IHaveNativeGuid.GUID => throw new NotImplementedException(); |
There was a problem hiding this comment.
is it intentional that this throws NotImplementedException ?
There was a problem hiding this comment.
For now. There is no guid for this that I can find anywhere. I plan on asking in the DX Discord to try and confirm.
There was a problem hiding this comment.
The DX Discord indicates this is by design and the interface only implements IUnknown for AddRef and Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of UTF-8 string literals and static abstracts in interfaces to make the code more readable, more maintainable, and more performant.