Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the yaml to ensure signing has the correct permissions #340

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fixing the yaml to ensure signing has the correct permissions #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 46 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,29 +37,43 @@ jobs:
env:
EXCLUDE_RUN_ID_FROM_PACKAGE: true
EXCLUDE_SUFFIX_FROM_VERSION: false
- uses: actions/upload-artifact@v3
with:
name: nuget_preview
path: |
./artifacts/bin/**/*
./artifacts/log/**/*
./artifacts/pkg/**/*
./artifacts/tst/**/*
if-no-files-found: error
sign-nuget-preview:
runs-on: windows-latest
if: ${{ github.event_name == 'push' }}
needs: [ build-nuget-preview ]
permissions:
id-token: write
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v2
with:
name: nuget_preview
path: ./artifacts
- uses: actions/setup-dotnet@v3
if: ${{ github.event_name == 'push' }}
with:
dotnet-version: '6.0.x'
- run: dotnet tool install --tool-path ./artifacts/tools sign --version 0.9.0-beta.23063.3
if: ${{ github.event_name == 'push' }}
- uses: azure/login@v1
if: ${{ github.event_name == 'push' }}
with:
allow-no-subscriptions: true
client-id: ${{ secrets.SC_AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.SC_AZURE_TENANT_ID }}
subscription-id: ${{ secrets.SC_AZURE_SUBSCRIPTION_ID }}
- run: ./artifacts/tools/sign code azure-key-vault "**/*.nupkg" --timestamp-url "http://timestamp.digicert.com" --base-directory "${{ github.workspace }}/artifacts/pkg" --file-list "${{ github.workspace }}/scripts/SignClientFileList.txt" --publisher-name "TerraFX" --description "TerraFX.Interop.Windows" --description-url "https://github.com/terrafx/terrafx.interop.windows" --azure-key-vault-managed-identity true --azure-key-vault-url "${{ secrets.SC_KEY_VAULT_URL }}" --azure-key-vault-certificate "${{ secrets.SC_KEY_VAULT_CERTIFICATE_ID }}"
if: ${{ github.event_name == 'push' }}
- uses: actions/upload-artifact@v3
with:
name: nuget_preview
name: sign_nuget_preview
path: |
./artifacts/bin/**/*
./artifacts/log/**/*
./artifacts/pkg/**/*
./artifacts/tst/**/*
if-no-files-found: error
build-nuget-release:
runs-on: windows-latest
Expand All @@ -70,34 +84,48 @@ jobs:
env:
EXCLUDE_RUN_ID_FROM_PACKAGE: true
EXCLUDE_SUFFIX_FROM_VERSION: true
- uses: actions/upload-artifact@v3
with:
name: nuget_release
path: |
./artifacts/bin/**/*
./artifacts/log/**/*
./artifacts/pkg/**/*
./artifacts/tst/**/*
if-no-files-found: error
sign-nuget-release:
runs-on: windows-latest
if: ${{ github.event_name == 'push' }}
needs: [ build-nuget-release ]
permissions:
id-token: write
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v2
with:
name: nuget_release
path: ./artifacts
- uses: actions/setup-dotnet@v3
if: ${{ github.event_name == 'push' }}
with:
dotnet-version: '6.0.x'
- run: dotnet tool install --tool-path ./artifacts/tools sign --version 0.9.0-beta.23063.3
if: ${{ github.event_name == 'push' }}
- uses: azure/login@v1
if: ${{ github.event_name == 'push' }}
with:
allow-no-subscriptions: true
client-id: ${{ secrets.SC_AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.SC_AZURE_TENANT_ID }}
subscription-id: ${{ secrets.SC_AZURE_SUBSCRIPTION_ID }}
- run: ./artifacts/tools/sign code azure-key-vault "**/*.nupkg" --timestamp-url "http://timestamp.digicert.com" --base-directory "${{ github.workspace }}/artifacts/pkg" --file-list "${{ github.workspace }}/scripts/SignClientFileList.txt" --publisher-name "TerraFX" --description "TerraFX.Interop.Windows" --description-url "https://github.com/terrafx/terrafx.interop.windows" --azure-key-vault-managed-identity true --azure-key-vault-url "${{ secrets.SC_KEY_VAULT_URL }}" --azure-key-vault-certificate "${{ secrets.SC_KEY_VAULT_CERTIFICATE_ID }}"
if: ${{ github.event_name == 'push' }}
- uses: actions/upload-artifact@v3
with:
name: nuget_release
name: sign_nuget_release
path: |
./artifacts/bin/**/*
./artifacts/log/**/*
./artifacts/pkg/**/*
./artifacts/tst/**/*
if-no-files-found: error
publish-nightlies-azure:
runs-on: ubuntu-latest
if: ${{ github.event_name == 'push' }}
needs: [ windows-x64, build-nuget-preview, build-nuget-release ]
needs: [ windows-x64, sign-nuget-preview, sign-nuget-release ]
steps:
- uses: actions/download-artifact@v2
with:
Expand All @@ -113,7 +141,7 @@ jobs:
publish-nightlies-github:
runs-on: ubuntu-latest
if: ${{ github.event_name == 'push' }}
needs: [ windows-x64, build-nuget-preview, build-nuget-release ]
needs: [ windows-x64, sign-nuget-preview, sign-nuget-release ]
steps:
- uses: actions/download-artifact@v2
with:
Expand Down