Generating bindings for WinTrust #37
Conversation
sources/Interop/WinTrust/um/wintrust/CRYPT_PROVIDER_DEFUSAGE.cs
Outdated
Show resolved
Hide resolved
sources/Interop/WinTrust/um/wintrust/CRYPT_PROVIDER_PRIVDATA.cs
Outdated
Show resolved
Hide resolved
| public IntPtr* pfnCertCheckPolicy; | ||
|
|
||
| [NativeTypeName("PFN_PROVIDER_TESTFINALPOLICY_CALL")] | ||
| public IntPtr* pfnTestFinalPolicy; |
There was a problem hiding this comment.
I think I borked this when I added the experimental function pointer support...
There was a problem hiding this comment.
It is supposed to be just IntPtr... I might just leave for now and fix when I regenerate the full bindings for 20H1
There was a problem hiding this comment.
Not sure what I can do to fix this.
sources/Interop/WinTrust/um/wintrust/CRYPT_PROVIDER_REGDEFUSAGE.cs
Outdated
Show resolved
Hide resolved
Pull request feedback
Pull request feedback #define mappings for WinTrust, Crypt32, and Advapi32
|
|
||
| public const int CERT_SYSTEM_STORE_LOCAL_MACHINE_WCOS = CERT_SYSTEM_STORE_LOCAL_MACHINE_WCOS_ID << CERT_SYSTEM_STORE_LOCATION_SHIFT; | ||
|
|
||
| public const string CERT_GROUP_POLICY_SYSTEM_STORE_REGPATH = |
There was a problem hiding this comment.
These are (mostly) just macro functions that weren't ported, right?
There was a problem hiding this comment.
I'm a bit confused about how your question relates to the code you highlighted. There are many #defines in wincrypt.h that are basically simple math expressions (like the one you highlighted). However, I did not port any macro functions at all throughout this PR (i.e., anything with #define F(X).
There was a problem hiding this comment.
The code you highlighted is defined thusly:
#define CERT_SYSTEM_STORE_LOCAL_MACHINE_WCOS \
(CERT_SYSTEM_STORE_LOCAL_MACHINE_WCOS_ID << \
CERT_SYSTEM_STORE_LOCATION_SHIFT)There was a problem hiding this comment.
For whatever reason, the "Conversation" tab puts this on the wrong line.
If you goto the "Files" tab, it is on L5919: https://github.com/terrafx/terrafx.interop.windows/pull/37/files/435c24606296062bd557b116d453c517e1e042cb#diff-d03360204625b1a7168b85116fe6c24bR5919
There was a problem hiding this comment.
Ah, yes, those are all the remaining #defines. The PowerShell script creates comments for every #define that couldn't be mapped automatically. I then go through the list and convert any that I feel like I can manage. Most of the leftovers are "functions."
|
Thanks for the contribution! |
Generating bindings for WinTrust
Generated bindings for
WinTrust.h.