Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HelloConstBuffer ported form C++ DirectX-Graphics-Samples #65

Merged
merged 23 commits into from
May 24, 2020
Merged

HelloConstBuffer ported form C++ DirectX-Graphics-Samples #65

merged 23 commits into from
May 24, 2020

Conversation

IngmarBitter
Copy link
Contributor

@IngmarBitter
Copy link
Contributor Author

Current state is that the compiler is happy, but runtime is not. Crashes on first try to SetGraphicsRootDescriptorTable when populating the command list. Parameters are not null. So something earlier is setting them with the wrong content. Hard to compare to the C++ edition at runtime to see where the divergence starts. My apologies for sending stuff as PR that crashes, but it seems that it only needs a minor tweak to get right.

IngmarBitter and others added 2 commits May 19, 2020 11:15
@IngmarBitter @tannergooding
Apply suggestions from code review
7616b6d 
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
@IngmarBitter IngmarBitter changed the title Added HelloConstBuffer form C++ HelloConstBuffer ported form C++ May 21, 2020
@IngmarBitter IngmarBitter changed the title HelloConstBuffer ported form C++ HelloConstBuffer ported form C++ DirectX-Graphics-Samples May 21, 2020
IngmarBitter and others added 13 commits May 22, 2020 20:19
@IngmarBitter
Added HelloConstBuffer form C++
f88c34f
@IngmarBitter
Descriptor heap setting fixed.
5314901
@IngmarBitter
fixed HelloConstBuffer12 instantiation
4090435
@IngmarBitter @tannergooding
Apply suggestions from code review
a7a7763 
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
@IngmarBitter
fixes after accepting all PR feedback. Compiler happy again. Run-time…
00f6175 
… is not.
@IngmarBitter @tannergooding
Apply suggestions from code review
c74c1de 
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
@IngmarBitter
HelloConstBuffer12.cs resolved all IntelliSense warnigs on coding style
7164d18
@IngmarBitter
_contstantBuffer disposed, _pCbvDataBegin not readonly
332b666
@IngmarBitter
Merge remote-tracking branch 'origin/HelloConstBuffers' into HelloCon…
1af72b8 
…stBuffers
@IngmarBitter
Merge branch 'master' into HelloConstBuffers
071ebac
@IngmarBitter
fixes after merge of upstream master
2a30572
@IngmarBitter
Merge branch 'master' into HelloConstBuffers
b88a1b1
@IngmarBitter
Merge branch 'master' into HelloConstBuffers
e39f5ac
@tannergooding
Copy link
Member

This looks good minus the #pragma, it can be merged once that is fixed.

@tannergooding tannergooding merged commit af51890 into terrafx:master May 24, 2020
@IngmarBitter IngmarBitter deleted the HelloConstBuffers branch March 17, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IngmarBitter @tannergooding