Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade LuaJIT to 2.1.0-beta3 #426

Merged
merged 10 commits into from
Apr 23, 2020

Conversation

elliottslaughter
Copy link
Member

As noted in #422 (comment), LuaJIT 2.0 is broken in macOS Catalina. Rather than following Homebrew and maintain custom patches for 2.0, just upgrade to 2.1 where the problem does not exist in the first place.

@elliottslaughter
Copy link
Member Author

I've confirmed that this is sufficient to get macOS Catalina 10.15 to build and pass all but 8 tests. Further progress is stalled on having a machine to actually debug on, but this might be enough to be worth taking even without having it 100% fixed, since it's clearly an improvement.

macOS 10.13 seems to be consistently failing leaktest.t on some configurations (according to Travis). I'll have to see if I can reproduce this locally. Currently this is the main blocker since it would be a regression (though maybe we don't care because it's only the Make build, apparently).

@elliottslaughter elliottslaughter force-pushed the luajit2.1-merge branch 2 times, most recently from 89fdcf5 to b0beb3a Compare April 22, 2020 17:02
@elliottslaughter
Copy link
Member Author

Well, the infamous leaktest.t is still failing. I am unable to reproduce locally, though it occurs non-deterministically on Travis. I was hoping to fix it by upgrading LuaJIT to the newest v2.1 branch on Git, but apparently it's still broken. So I think this is still a blocker at this point, unfortunately. I suppose we could add an official luajit2.1 branch to the main Terra repo, but I don't want to pull this into master if it's causing failures like this.

@elliottslaughter
Copy link
Member Author

As I wrote in #404, I think the failures are fundamental to the design and guarantees that the GC provides in LuaJIT. I've now seen leaktest.t fail on all OSes (and really, I've probably been ignoring them for a while, I vaguely recall having to turn off various configurations to avoid this in the past).

It was necessary to update past the most recent LuaJIT beta; there were failures even aside from leaktest.

The tests are now clean so I'm going to merge this.

@elliottslaughter elliottslaughter merged commit 6599de5 into terralang:master Apr 23, 2020
@elliottslaughter elliottslaughter deleted the luajit2.1-merge branch April 23, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant