-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade LuaJIT to 2.1.0-beta3 #426
Upgrade LuaJIT to 2.1.0-beta3 #426
Conversation
I've confirmed that this is sufficient to get macOS Catalina 10.15 to build and pass all but 8 tests. Further progress is stalled on having a machine to actually debug on, but this might be enough to be worth taking even without having it 100% fixed, since it's clearly an improvement. macOS 10.13 seems to be consistently failing |
89fdcf5
to
b0beb3a
Compare
Well, the infamous |
7633f97
to
37630d0
Compare
37630d0
to
0c68a75
Compare
As I wrote in #404, I think the failures are fundamental to the design and guarantees that the GC provides in LuaJIT. I've now seen It was necessary to update past the most recent LuaJIT beta; there were failures even aside from leaktest. The tests are now clean so I'm going to merge this. |
As noted in #422 (comment), LuaJIT 2.0 is broken in macOS Catalina. Rather than following Homebrew and maintain custom patches for 2.0, just upgrade to 2.1 where the problem does not exist in the first place.