Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LLVM 10 and 11 #434

Merged
merged 38 commits into from
Jan 23, 2021
Merged

Conversation

elliottslaughter
Copy link
Member

@elliottslaughter elliottslaughter commented Apr 14, 2020

This should now be working. There is a list of caveats below, but it's close enough that I'm going to merge and track remaining failures via issues.

Known issues at time of merge:

@elliottslaughter elliottslaughter mentioned this pull request Jan 19, 2021
@elliottslaughter
Copy link
Member Author

The remaining two issues seem to both be in C header includes:

  • strerror.t: tries to include("string.h) but it can't find strerror_r
  • expvec.t: hits a boatload of compile errors trying to include immintrin.h

@elliottslaughter elliottslaughter changed the title Support for LLVM 10 Support for LLVM 10 and 11 Jan 21, 2021
@elliottslaughter
Copy link
Member Author

I pushed a new set of patches that add support for LLVM 11. I was hoping this was going to fix some of the other broken tests in LLVM 10, but no luck.

One test I was able to work around, the others are marked as caveats in the top post of this PR.

@elliottslaughter
Copy link
Member Author

I had to give up on macOS due to some sort of odd build error, but it's finally passing (modulo caveats above).

@elliottslaughter
Copy link
Member Author

Actually, based on the error message it may be an issue with the LLVM binaries. It seems they now depend on having XCode installed:

make[2]: *** No rule to make target `/Applications/Xcode_12.0.0_fb.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/lib/libxml2.tbd', needed by `bin/terra'.  Stop.

If that's the case this may go away if I build from source.

@elliottslaughter
Copy link
Member Author

elliottslaughter commented Jan 22, 2021

It's still failing with the binary I built on my local machine (though my local build works). Next step is to attempt to build on Github Actions itself (under the theory that the software setup should be compatible). It would suck if LLVM binaries are no longer sufficiently generic to be used everywhere, but if it gets CI passing it will at least be better than nothing.

@elliottslaughter
Copy link
Member Author

The build is indeed successful when LLVM is built on Github Actions. I'm still getting issues including header files though, and the macOS image seems not to have the 10.15 SDK installed. So I think I'm stuck at this point.

At this point I'm frustrated enough with macOS that I'm going to go forward with the merge and leave the remaining items to be fixed at a future date.

@elliottslaughter elliottslaughter merged commit 968c816 into terralang:master Jan 23, 2021
@elliottslaughter elliottslaughter deleted the llvm-10 branch January 23, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant