-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for LLVM 10 and 11 #434
Conversation
2f5f059
to
27f417a
Compare
27f417a
to
c82d3a6
Compare
The remaining two issues seem to both be in C header includes:
|
I pushed a new set of patches that add support for LLVM 11. I was hoping this was going to fix some of the other broken tests in LLVM 10, but no luck. One test I was able to work around, the others are marked as caveats in the top post of this PR. |
I had to give up on macOS due to some sort of odd build error, but it's finally passing (modulo caveats above). |
Actually, based on the error message it may be an issue with the LLVM binaries. It seems they now depend on having XCode installed:
If that's the case this may go away if I build from source. |
It's still failing with the binary I built on my local machine (though my local build works). Next step is to attempt to build on Github Actions itself (under the theory that the software setup should be compatible). It would suck if LLVM binaries are no longer sufficiently generic to be used everywhere, but if it gets CI passing it will at least be better than nothing. |
…ible header files.
…incompatible header files." This reverts commit 927cfd3.
The build is indeed successful when LLVM is built on Github Actions. I'm still getting issues including header files though, and the macOS image seems not to have the 10.15 SDK installed. So I think I'm stuck at this point. At this point I'm frustrated enough with macOS that I'm going to go forward with the merge and leave the remaining items to be fixed at a future date. |
This should now be working. There is a list of caveats below, but it's close enough that I'm going to merge and track remaining failures via issues.
Known issues at time of merge:
Build failure with LLVM >= 10 on macOS #478 doesn't build on macOS with LLVM >= 10