-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Terra on macOS Movaje #435
Merged
elliottslaughter
merged 30 commits into
terralang:master
from
elliottslaughter:fix-mojave
Apr 22, 2020
Merged
Fix Terra on macOS Movaje #435
elliottslaughter
merged 30 commits into
terralang:master
from
elliottslaughter:fix-mojave
Apr 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a long road, but I finally have Terra building and passing all tests on macOS Mojave without the workaround suggested in #365.
Caveats:
.a
files, and I don't currently have time (or interest) to debug it.-DCMAKE_C_COMPILER=$(which CC)
, because apparently CMake tries to auto-detect the XCode installation, and LuaJIT can't build with that compiler. I've got into a VM to confirm this behavior but don't have time to debug it.INCLUDE_PATH="$(xcrun --sdk macosx --show-sdk-path)/usr/include"
. I thought this was going to fixed by this patch but apparently not. This may indicate we're still not getting all of the Clang initialization right.