Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Terra on macOS Movaje #435

Merged
merged 30 commits into from
Apr 22, 2020

Conversation

elliottslaughter
Copy link
Member

@elliottslaughter elliottslaughter commented Apr 22, 2020

It's been a long road, but I finally have Terra building and passing all tests on macOS Mojave without the workaround suggested in #365.

Caveats:

  • It requires CMake. Make fails somewhere in the step where we run a Lua script to unpack the .a files, and I don't currently have time (or interest) to debug it.
  • It requires passing -DCMAKE_C_COMPILER=$(which CC), because apparently CMake tries to auto-detect the XCode installation, and LuaJIT can't build with that compiler. I've got into a VM to confirm this behavior but don't have time to debug it.
  • It still requires setting INCLUDE_PATH="$(xcrun --sdk macosx --show-sdk-path)/usr/include". I thought this was going to fixed by this patch but apparently not. This may indicate we're still not getting all of the Clang initialization right.
  • It includes a workaround for Thread-local storage on macOS Mojave, minimum OSX_DEPLOYMENT_TARGET LuaJIT/LuaJIT#575, which at the moment means we bump the deployment target to 10.7. Shouldn't matter for most users but if you want to use a LuaJIT 2.1 build from Git, this is now required.

This reverts commit f217a96.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant