Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move init command inside the stacks command #122

Merged
merged 4 commits into from
Dec 31, 2021
Merged

move init command inside the stacks command #122

merged 4 commits into from
Dec 31, 2021

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Dec 30, 2021

No description provided.

@i4ki i4ki requested a review from katcipis December 30, 2021 19:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #122 (de1d6e9) into main (e2135e0) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   73.29%   73.20%   -0.10%     
==========================================
  Files          27       28       +1     
  Lines        2760     2885     +125     
==========================================
+ Hits         2023     2112      +89     
- Misses        556      581      +25     
- Partials      181      192      +11     
Flag Coverage Δ
tests 73.20% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 63.18% <100.00%> (-1.30%) ⬇️
order.go 71.87% <0.00%> (-18.42%) ⬇️
hcl/hcl.go 77.86% <0.00%> (-0.52%) ⬇️
run.go 64.70% <0.00%> (ø)
hcl/printer.go 100.00% <0.00%> (ø)
dag/dag.go 91.26% <0.00%> (ø)
test/sandbox/sandbox.go 81.90% <0.00%> (+0.18%) ⬆️
manager.go 51.32% <0.00%> (+0.52%) ⬆️
stack/stack.go 86.36% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2135e0...de1d6e9. Read the comment docs.

@i4ki i4ki marked this pull request as draft December 30, 2021 19:34
@i4ki i4ki marked this pull request as ready for review December 30, 2021 19:37
Copy link
Contributor

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from what I can see and taking into consideration that my Go knowledge isn't that great! Thanks for the contribution @i4ki ! Appreciated!

@i4ki i4ki merged commit c49ed53 into main Dec 31, 2021
@i4ki i4ki deleted the i4k/move-stack-cmds branch December 31, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants