Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stacks listed twice #149

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix: stacks listed twice #149

merged 1 commit into from
Jan 10, 2022

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jan 10, 2022

The root cause was stacks listed twice and the incorrect one was missing the changed flag, so the run-order put them in a map, randomly overwriting the entry, so in the end stacks could have a changed flag or not, so the run-order was broken.

It's a bit hard to reproduce because it only happens when a stack detected as changed also had a module that changed, so I'm going to provide a testcase later this week.

@i4ki i4ki requested a review from katcipis January 10, 2022 10:24
@codecov-commenter
Copy link

Codecov Report

Merging #149 (d5acd04) into main (92d3679) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   60.72%   60.69%   -0.03%     
==========================================
  Files          29       29              
  Lines        4524     4526       +2     
==========================================
  Hits         2747     2747              
- Misses       1629     1631       +2     
  Partials      148      148              
Flag Coverage Δ
tests 60.69% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager.go 67.57% <100.00%> (+0.50%) ⬆️
stack/loader.go 50.94% <0.00%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d3679...d5acd04. Read the comment docs.

@i4ki i4ki requested a review from mariux January 10, 2022 10:25
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 🚀

@i4ki i4ki merged commit 2325788 into main Jan 10, 2022
@i4ki i4ki deleted the i4k/fix-change-detection branch January 10, 2022 12:07
i4ki added a commit that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants