Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print metadata filtered by cwd #167

Merged
merged 9 commits into from
Jan 14, 2022
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jan 14, 2022

No description provided.

@i4ki i4ki requested a review from katcipis January 14, 2022 17:40
Base automatically changed from i4k/refactor-meta to main January 14, 2022 20:40
@codecov-commenter
Copy link

Codecov Report

Merging #167 (14ecfdc) into main (bb8f48c) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   60.83%   60.74%   -0.09%     
==========================================
  Files          28       28              
  Lines        4698     4703       +5     
==========================================
- Hits         2858     2857       -1     
- Misses       1677     1683       +6     
  Partials      163      163              
Flag Coverage Δ
tests 60.74% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 0.00% <0.00%> (ø)
manager.go 67.48% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8f48c...14ecfdc. Read the comment docs.

Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests 💯

@@ -722,6 +722,12 @@ func (c *cli) printMetadata() {
Msg("listing stacks")
}

stackEntries = c.filterStacksByWorkingDir(stackEntries)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice :-)

stack "/somedir/stack4":
terramate.name="stack4"
terramate.path="/somedir/stack4"
terramate.description=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add later, but here we are also missing the scenario where wd is a dir with no stacks inside (like we tested for globals listing).

@i4ki i4ki merged commit 1b5eae4 into main Jan 14, 2022
@i4ki i4ki deleted the i4k/print-metadata-filter-cwd branch January 14, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants