Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements the wants attribute for pulling other stacks. #182

Merged
merged 39 commits into from
Jan 24, 2022
Merged

feat: implements the wants attribute for pulling other stacks. #182

merged 39 commits into from
Jan 24, 2022

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jan 20, 2022

No description provided.

@i4ki i4ki changed the base branch from main to i4k/refactor-loader January 20, 2022 04:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #182 (2b6dbca) into main (8d5f38d) will decrease coverage by 0.65%.
The diff coverage is 8.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   60.62%   59.97%   -0.66%     
==========================================
  Files          28       28              
  Lines        4698     4759      +61     
==========================================
+ Hits         2848     2854       +6     
- Misses       1685     1740      +55     
  Partials      165      165
Flag Coverage Δ
tests 59.97% <8.18%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 0.00% <0.00%> (ø)
hcl/hcl.go 78.44% <0.00%> (-1.10%) ⬇️
manager.go 60.79% <0.00%> (-6.70%) ⬇️
run/order.go 0.00% <0.00%> (ø)
stack/loader.go 53.52% <0.00%> (+0.37%) ⬆️
stack/stack.go 77.77% <14.28%> (-5.36%) ⬇️
hcl/printer.go 100.00% <100.00%> (ø)
test/sandbox/sandbox.go 84.27% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5f38d...2b6dbca. Read the comment docs.

@i4ki i4ki requested a review from katcipis January 20, 2022 04:31
@i4ki i4ki marked this pull request as draft January 20, 2022 04:32
@i4ki i4ki marked this pull request as ready for review January 20, 2022 04:41
i4ki and others added 10 commits January 20, 2022 12:22
@i4ki
tests: more testcases
9d86911
@i4ki
Merge branch 'main' of github.com:mineiros-io/terramate into i4k/refa…
833fff4 
…ctor-stack
@i4ki @katcipis
Update init.go
4d96f4e 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@i4ki
Merge branch 'i4k/refactor-stack' of github.com:mineiros-io/terramate…
cbb51f7 
… into i4k/refactor-stack
@i4ki
docs: improve documentation
76d2050
@i4ki @katcipis
Update init.go
9132ec9 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@i4ki
fix: silently ignoring close error
5034356
@i4ki @katcipis
Update project/project.go
c97b36e 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@i4ki
Merge branch 'i4k/refactor-stack' of github.com:mineiros-io/terramate…
6f2a70a 
… into i4k/refactor-stack-paths
@i4ki
Merge branch 'i4k/refactor-stack-paths' of github.com:mineiros-io/ter…
785505a 
…ramate into i4k/refactor-stack-paths
katcipis
katcipis previously approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 + non-blocking stuff / me being stupid / the usual

cmd/terramate/cli/cli.go Outdated Show resolved Hide resolved
cmd/terramate/cli/cli.go Outdated Show resolved Hide resolved
cmd/terramate/e2etests/run_test.go Show resolved Hide resolved
manager.go Outdated Show resolved Hide resolved
manager.go Outdated Show resolved Hide resolved
manager.go Outdated Show resolved Hide resolved
stack/loader.go Outdated Show resolved Hide resolved
test/sandbox/sandbox.go Outdated Show resolved Hide resolved
i4ki and others added 2 commits January 21, 2022 13:49
@i4ki
merge with main
7ef664c
@i4ki @katcipis
Update stack/loader.go
7708cd8 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
i4ki and others added 8 commits January 21, 2022 14:06
@i4ki @katcipis
Update stack/loader.go
e4b248b 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@i4ki
merge with base branch
cfdfb02
@i4ki
Merge branch 'i4k/refactor-loader' of github.com:mineiros-io/terramat…
6032481 
…e into i4k/refactor-loader
@i4ki @katcipis
Update cmd/terramate/cli/cli.go
9241587 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@i4ki @katcipis
Update cmd/terramate/cli/cli.go
4a8d0b0 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@i4ki @katcipis
Update manager.go
21c5401 
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@i4ki
Merge branch 'i4k/refactor-loader' of github.com:mineiros-io/terramat…
e802940 
…e into i4k/wants-feature
@i4ki
style: improve from review
5fddb44
katcipis
katcipis reviewed Jan 21, 2022
View reviewed changes
stack/loader.go Outdated Show resolved Hide resolved
mariux
mariux reviewed Jan 23, 2022
View reviewed changes
Copy link
Contributor

@mariux mariux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ lgtm

Base automatically changed from i4k/refactor-loader to main January 24, 2022 11:24
@i4ki i4ki requested a review from katcipis January 24, 2022 12:06
@i4ki i4ki merged commit fbe8270 into main Jan 24, 2022
@i4ki i4ki deleted the i4k/wants-feature branch January 24, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariux mariux mariux left review comments

@katcipis katcipis katcipis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@i4ki @codecov-commenter @katcipis @mariux