-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generate config loading #186
Conversation
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 60.56% 61.13% +0.56%
==========================================
Files 28 29 +1
Lines 4694 4914 +220
==========================================
+ Hits 2843 3004 +161
- Misses 1686 1738 +52
- Partials 165 172 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @katcipis... can you give a short demo to me tomorrow about the changes? really interested how this works ... thanks a lot..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
} | ||
cfg.BackendCfgFilename = attrVal.AsString() | ||
|
||
logger.Trace().Msg("parsed with success") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice =)
Not yet because this PR is the core logic but it is not integrated to the code generation itself, but integrating should be fast (but not done yet). After the follow up PR we are good for demo time (when I make changes on the cli level I always add some demo script, usually very simple but with some demo value =P). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Tiago de Bem Natel de Moura <t.nateldemoura@gmail.com>
Adds:
Integration on actual code generation (and check) will be done on a separate PR, should be considerably smaller since this is the core logic and the other functions will only get the loaded config as a parameter.