refactor: parallel generate #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
i4ki
force-pushed
the
i4k-parallel-generate
branch
2 times, most recently
from
d4d188d
to
b67ed7d
Compare
Signed-off-by: i4k <t.nateldemoura@gmail.com>
i4ki
force-pushed
the
i4k-parallel-generate
branch
from
b67ed7d
to
334b278
Compare
Preview of ubuntu-focal/go1.21 tests in 63c22da🔍 View Details on Terramate Cloud .
cmd/terramate/cli
config
generate
modvendor/download
stdlib
test/sandbox
|
Preview of macos-ventura/go1.21 tests in 63c22da🔍 View Details on Terramate Cloud .
cmd/terramate/cli
config
generate
modvendor/download
stdlib
test/sandbox
|
Signed-off-by: i4k <t.nateldemoura@gmail.com>
Signed-off-by: i4k <t.nateldemoura@gmail.com>
soerenmartius
previously approved these changes
Oct 22, 2024
There was a problem hiding this comment.
This is awesome, shall we get this documented by @AnnuCode ?
Signed-off-by: i4k <t.nateldemoura@gmail.com>
|
@soerenmartius yes, please! |
soerenmartius
approved these changes
Oct 23, 2024
This was referenced Oct 23, 2024
snakster
approved these changes
Oct 24, 2024
i4ki
added a commit
that referenced
this pull request
Oct 24, 2024
…ation (#1943) ## What this PR does / why we need it: The in-place AST modifications were a nice optimization when generation was serial but with the introduction of #1937 it's racy. ## Which issue(s) this PR fixes: none ## Special notes for your reviewer: ## Does this PR introduce a user-facing change? ``` no ```
i4ki
added a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces parallel code generation.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?