Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use default logging before parsing cli args #204

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: use default logging before parsing cli args #204

merged 1 commit into from
Feb 8, 2022

Conversation

katcipis
Copy link
Contributor

@katcipis katcipis commented Feb 7, 2022

Now logging done before configuring the log library will have the same default level/format as the ones configured for the cli options. Now we get this:

terramate wrong
2022-02-07T18:54:57+01:00 FTL failed to parse cli args: [wrong] error="unexpected argument wrong" action=newCli()

Instead of JSON (which is not the default).

kassianh
kassianh approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@kassianh kassianh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katcipis katcipis merged commit 82f2968 into main Feb 8, 2022
@katcipis katcipis deleted the katcipis-setup-default-logging-before-cli-parse branch February 8, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassianh kassianh kassianh approved these changes

@mariux mariux Awaiting requested review from mariux

@thiesen thiesen Awaiting requested review from thiesen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katcipis @kassianh