Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release process: remove explicit permissions setting #214

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

katcipis
Copy link
Contributor

@katcipis katcipis commented Feb 10, 2022

I copied the permissions setting from the goreleaser example here, but that just broke the publish of docker images + introduces different behavior on different workflows (I was debugging on a different workflow). So lets just go with defaults, it should be enough for go releaser as can be seen here.

@katcipis katcipis self-assigned this Feb 10, 2022
@katcipis katcipis changed the title chore: fix release process: remove explicit permissions setting chore: release process: remove explicit permissions setting Feb 10, 2022
Copy link
Contributor

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@kassianh kassianh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katcipis katcipis merged commit da8b33f into main Feb 11, 2022
@katcipis katcipis deleted the katcipis-remove-explicit-permissions-release-wf branch February 11, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants