Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git safeguards not using root config.git #234

Merged
merged 4 commits into from
Feb 25, 2022
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Feb 24, 2022

No description provided.

@i4ki i4ki requested a review from katcipis February 24, 2022 17:35
katcipis
katcipis previously approved these changes Feb 24, 2022
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + minor comment

cmd/terramate/cli/cli.go Show resolved Hide resolved
cmd/terramate/cli/cli.go Outdated Show resolved Hide resolved
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #234 (d755451) into main (d091fdc) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   64.93%   65.02%   +0.08%     
==========================================
  Files          30       30              
  Lines        5613     5613              
==========================================
+ Hits         3645     3650       +5     
+ Misses       1783     1779       -4     
+ Partials      185      184       -1     
Flag Coverage Δ
tests 65.02% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 0.00% <0.00%> (ø)
hcl/hcl.go 84.21% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d091fdc...d755451. Read the comment docs.

@i4ki i4ki merged commit 409f724 into main Feb 25, 2022
@i4ki i4ki deleted the i4k/fix-git-config-cli branch February 25, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants