feat: prohibits stacks from having child stacks (non-leaf stacks) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i4ki
commented
Dec 15, 2021
i4ki
commented
Dec 15, 2021
i4ki
commented
Dec 15, 2021
i4ki
commented
Dec 15, 2021
katcipis
previously approved these changes
Dec 15, 2021
hcl/hcl.go
Outdated
Comment on lines
52
to
54
| // After is a list of non-duplicated stack entries that must run after the | ||
| // current stack runs. | ||
| After []string |
There was a problem hiding this comment.
This is related to ordering, shouldn't it be only on the order of exec PR ?
hcl/hcl.go
Outdated
| ErrNoTerramateBlock errutil.Error = "no \"terramate\" block found" | ||
| ErrMalformedTerramateConfig errutil.Error = "malformed terramate config" | ||
| ErrMalformedTerraform errutil.Error = "malformed terraform" | ||
| ErrStackInvalidRunOrder errutil.Error = "invalid stack execution order definition" |
There was a problem hiding this comment.
Order related change, maybe add this on the order of exec PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.