Facemaps are a defunct ARMI concept #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also adds some unrelated tests, purely for code coverage.
john-science
added
cleanup
|
Might want to remove the link to the facemap page here: https://terrapower.github.io/armi/user/inputs/blueprints.html#grids |
youngmit
suggested changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove the Facemap input file section in our docs. As that input file no longer exists, and is a redundant concept. Also, it was quite short, practically a stub, I couldn't find any useful information to move out into our blueprint grid docs.
Thanks to @keckler for issue #447
(This PR also adds some unrelated tests, purely for code coverage.)