Add component group capabilities #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-science
approved these changes
Jan 6, 2022
ntouran
changed the title
john-science
reviewed
Jan 7, 2022
| @@ -204,10 +204,6 @@ def test_fromComponent(self): | |||
| class TestShapedComponent(TestGeneralComponents): | |||
| """Abstract class for all shaped components""" | |||
|
|
|||
| def test_getBoundingCircleOuterDiameter(self): | |||
There was a problem hiding this comment.
Why are we removing this test?
There was a problem hiding this comment.
because we implemented it! but you're right, we should just update the test to actually test it, eh?
ntouran
commented
Jan 7, 2022
ntouran
force-pushed
the
componentgroups
branch
from
a6b533f to
089506d
Compare
|
Hey Nick. Can you address the two conversations above? I just want to merge this PR, and it looks like they will both be fast. |
This allows the user to input component groups intended to mix different free components in different fractions. It is a follow-up to terrapower#505 as part of the larger terrapower#504 task related to improving input flexibility. This implements the addition of groups of components to blocks, which can be used to create more complex and flexible models. The code changes solved a few residual issues where iterating over the children of a block were assuming all children would be Components. Now they can be Composites with multiple Components or Components. Some upgrades to DerivedShapes were necessary so that they could work with volumetric components in addition to pure 2D ones. These are additional steps toward terrapower#504, but true practical usage of these groups is not quite done yet. More followups are needed. Added a new test covering negative volume in derived shapes
ntouran
force-pushed
the
componentgroups
branch
from
2ef113d to
e495ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This just allows the user input of component groups intended to mix
different free components in different fractions. As is, this only
allows the input but does not implement any actual construction of
objects. It is a follow-up to #505 as part of the larger #504 task
related to improving input flexibility.
This needs to have a test that shows it reading/writing to/from
the database.
Checklist
If user exposed functionality was added/changed:
docfolder.setup.py.