Merge pull request #1108 from gavin-ts/bold-edge-label

fix: bold edge label padding
terrastruct · Mar 30, 2023 · d46c3ed · d46c3ed
2 parents 3dfafca + 505207a
commit d46c3ed
Show file tree

Hide file tree

Showing 7 changed files with 744 additions and 1 deletion.
diff --git a/ci/release/changelogs/next.md b/ci/release/changelogs/next.md
@@ -11,3 +11,4 @@
 #### Bugfixes ⛑️
 
 - prevent an object's `near` from targeting a text near a constant. [#1100](https://github.com/terrastruct/d2/pull/1100)
+- fixes inaccurate bold edge label padding. [#1108](https://github.com/terrastruct/d2/pull/1108)
diff --git a/d2graph/d2graph.go b/d2graph/d2graph.go
@@ -1032,10 +1032,14 @@ func (e *Edge) Text() *d2target.MText {
 	if e.Attributes.Style.FontSize != nil {
 		fontSize, _ = strconv.Atoi(e.Attributes.Style.FontSize.Value)
 	}
+	isBold := false
+	if e.Attributes.Style.Bold != nil {
+		isBold, _ = strconv.ParseBool(e.Attributes.Style.Bold.Value)
+	}
 	return &d2target.MText{
 		Text:     e.Attributes.Label.Value,
 		FontSize: fontSize,
-		IsBold:   false,
+		IsBold:   isBold,
 		IsItalic: true,
 
 		Dimensions: e.LabelDimensions,

diff --git a/e2etests/regression_test.go b/e2etests/regression_test.go
@@ -646,6 +646,16 @@ l3c2.c -> l4.c3.c`,
 			name:   "link_with_ampersand",
 			script: `a.link: https://calendar.google.com/calendar/u/0/r?tab=mc&pli=1`,
 		},
+		{
+			name: "bold_edge_label",
+			script: `
+direction: right
+x -> y: sync
+y -> z: sync {
+	style.bold: true
+}
+`,
+		},
 	}
 
 	runa(t, tcs)

diff --git a/e2etests/testdata/regression/bold_edge_label/dagre/board.exp.json b/e2etests/testdata/regression/bold_edge_label/dagre/board.exp.json
Original file line number	Diff line number	Diff line change
Expand Up		@@ -11,3 +11,4 @@
		#### Bugfixes ⛑️

		- prevent an object's `near` from targeting a text near a constant. [#1100](https://github.com/terrastruct/d2/pull/1100)
		- fixes inaccurate bold edge label padding. [#1108](https://github.com/terrastruct/d2/pull/1108)