Grid gap keywords

[gavin-ts]

Summary

Adds grid-gap, vertical-gap, and horizontal-gap keywords to customize gap size in grids.

Details

• fixes customize gap sizes in grid diagram #1146
• adds grid_gap test
• grid-gap sets both, vertical-gap and horizontal-gap sets only rows or columns (and overrides grid-gap if specified)

before/after

[alixander]

gap 0 looks particularly useful.

[ejulio-ts]

I don't have any preference, but I wonder which one is better grid-gap-rows or grid-rows-gap.

[alixander]

oh true, we should flip it to match what css chose:

grid-row-gap

[alixander]

actually maybe this is an opportunity to just let users control vertical/horizontal spacing between nodes. can be used for sequence diagrams and others too: #1183

vertical-gap and horizontal-gap

[gavin-ts]

actually maybe this is an opportunity to just let users control vertical/horizontal spacing between nodes. can be used for sequence diagrams and others too: #1183

vertical-gap and horizontal-gap

so we are deciding between gap, vertical-gap, horizontal-gap and grid-gap, grid-row-gap, grid-column-gap?

another option is gap, row-gap, and column-gap https://developer.mozilla.org/en-US/docs/Web/CSS/gap

[alixander]

let's do grid-gap, vertical-gap and horizontal-gap.

in a grid, the shorthand for both is useful. but when used elsewhere, it's not.