Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2 0.4.1 #128674

Merged
merged 2 commits into from
Apr 18, 2023
Merged

d2 0.4.1 #128674

merged 2 commits into from
Apr 18, 2023

Conversation

ZhongRuoyu
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
Multi-board D2 compositions now get 2 more useful formats to export to: PowerPoint and GIFs.

Powerpoint example

Make sure you click present, and click around the links and navigations!

GIF example

This is the same diagram as one we shared when we announced animated SVGs, but in GIF form.

animated

Features 🚀

  • Export diagrams to .pptx (PowerPoint) #1139
  • Export diagrams to .gif #1200
  • Customize gap size in grid diagrams with grid-gap, vertical-gap, or horizontal-gap (see docs) #1178
  • New dark theme "Dark Terrastruct Flagship" with the theme ID of 201 #1150

Improvements 🧹

  • font-size works with Markdown text #1191
  • SVG outputs for internal links use relative paths instead of absolute #1197
  • Improves arrowhead label positioning #1207

Bugfixes ⛑️

  • Fixes grid layouts not applying on objects with a constant near #1173
  • Fixes Markdown header rendering in Firefox and Safari #1177
  • Fixes a grid layout panic when there are fewer objects than rows/columns #1189
  • Fixes an issue where PNG exports that were too large were crashing #1093

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Apr 18, 2023
Moisan
Moisan previously approved these changes Apr 18, 2023
@github-actions
Copy link
Contributor

🤖 A scheduled task has requested bottles to be published to this PR.

@github-actions
Copy link
Contributor

⚠️ Bottle publish failed. CC @carlocab

@BrewTestBot BrewTestBot dismissed Moisan’s stale review April 18, 2023 14:19

bottle publish failed

@carlocab
Copy link
Member

carlocab commented Apr 18, 2023

I was looking into why brew thinks the workflow run is still in progress but now it really is still in progress 😭

I was wondering why my GraphQL query suddenly started giving me a different workflow ID! (I hate GraphQL.)

@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Apr 18, 2023

Sorry 🥺

Force-pushing is the workaround I've been using. It's not the first time I'm seeing this. (#128308 (comment) was the first time I think. The API response really suggested that the run was in progress so I don't think it's brew's fault.) But I'll let you know when I see this again.

@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Apr 18, 2023

By the way, the run before the force-push is still in_progress:

$ gh api repos/Homebrew/homebrew-core/actions/runs/4732670212 -q .status
in_progress

But there's already a conclusion:

$ gh api repos/Homebrew/homebrew-core/actions/runs/4732670212 -q .conclusion
success

Perhaps it was related to the webhook delay?

Full response
{
  "id": 4732670212,
  "name": "CI",
  "node_id": "WFR_kwLOAyaC3M8AAAABGhbRBA",
  "head_branch": "bump-d2-0.4.1",
  "head_sha": "72d9782e79025f2a3de78b67afe8e7f3d1fd7ab1",
  "path": ".github/workflows/tests.yml",
  "display_title": "d2 0.4.1",
  "run_number": 221868,
  "event": "pull_request",
  "status": "in_progress",
  "conclusion": "success",
  "workflow_id": 645528,
  "check_suite_id": 12313162953,
  "check_suite_node_id": "CS_kwDOAyaC3M8AAAAC3ev0yQ",
  "url": "https://api.github.com/repos/Homebrew/homebrew-core/actions/runs/4732670212",
  "html_url": "https://github.com/Homebrew/homebrew-core/actions/runs/4732670212",
  "pull_requests": [],
  "created_at": "2023-04-18T13:00:35Z",
  "updated_at": "2023-04-18T13:44:18Z",
  "actor": {
    "login": "ZhongRuoyu",
    "id": 25842576,
    "node_id": "MDQ6VXNlcjI1ODQyNTc2",
    "avatar_url": "https://avatars.githubusercontent.com/u/25842576?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/ZhongRuoyu",
    "html_url": "https://github.com/ZhongRuoyu",
    "followers_url": "https://api.github.com/users/ZhongRuoyu/followers",
    "following_url": "https://api.github.com/users/ZhongRuoyu/following{/other_user}",
    "gists_url": "https://api.github.com/users/ZhongRuoyu/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/ZhongRuoyu/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/ZhongRuoyu/subscriptions",
    "organizations_url": "https://api.github.com/users/ZhongRuoyu/orgs",
    "repos_url": "https://api.github.com/users/ZhongRuoyu/repos",
    "events_url": "https://api.github.com/users/ZhongRuoyu/events{/privacy}",
    "received_events_url": "https://api.github.com/users/ZhongRuoyu/received_events",
    "type": "User",
    "site_admin": false
  },
  "run_attempt": 1,
  "referenced_workflows": [],
  "run_started_at": "2023-04-18T13:00:35Z",
  "triggering_actor": {
    "login": "ZhongRuoyu",
    "id": 25842576,
    "node_id": "MDQ6VXNlcjI1ODQyNTc2",
    "avatar_url": "https://avatars.githubusercontent.com/u/25842576?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/ZhongRuoyu",
    "html_url": "https://github.com/ZhongRuoyu",
    "followers_url": "https://api.github.com/users/ZhongRuoyu/followers",
    "following_url": "https://api.github.com/users/ZhongRuoyu/following{/other_user}",
    "gists_url": "https://api.github.com/users/ZhongRuoyu/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/ZhongRuoyu/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/ZhongRuoyu/subscriptions",
    "organizations_url": "https://api.github.com/users/ZhongRuoyu/orgs",
    "repos_url": "https://api.github.com/users/ZhongRuoyu/repos",
    "events_url": "https://api.github.com/users/ZhongRuoyu/events{/privacy}",
    "received_events_url": "https://api.github.com/users/ZhongRuoyu/received_events",
    "type": "User",
    "site_admin": false
  },
  "jobs_url": "https://api.github.com/repos/Homebrew/homebrew-core/actions/runs/4732670212/jobs",
  "logs_url": "https://api.github.com/repos/Homebrew/homebrew-core/actions/runs/4732670212/logs",
  "check_suite_url": "https://api.github.com/repos/Homebrew/homebrew-core/check-suites/12313162953",
  "artifacts_url": "https://api.github.com/repos/Homebrew/homebrew-core/actions/runs/4732670212/artifacts",
  "cancel_url": "https://api.github.com/repos/Homebrew/homebrew-core/actions/runs/4732670212/cancel",
  "rerun_url": "https://api.github.com/repos/Homebrew/homebrew-core/actions/runs/4732670212/rerun",
  "previous_attempt_url": null,
  "workflow_url": "https://api.github.com/repos/Homebrew/homebrew-core/actions/workflows/645528",
  "head_commit": {
    "id": "72d9782e79025f2a3de78b67afe8e7f3d1fd7ab1",
    "tree_id": "4e85c5c5f90ebe691d8dfa330aca9130ce6d5711",
    "message": "d2 0.4.1",
    "timestamp": "2023-04-18T13:00:24Z",
    "author": {
      "name": "Ruoyu Zhong",
      "email": "zhongruoyu@outlook.com"
    },
    "committer": {
      "name": "Ruoyu Zhong",
      "email": "zhongruoyu@outlook.com"
    }
  },
  "repository": {
    "id": 52855516,
    "node_id": "MDEwOlJlcG9zaXRvcnk1Mjg1NTUxNg==",
    "name": "homebrew-core",
    "full_name": "Homebrew/homebrew-core",
    "private": false,
    "owner": {
      "login": "Homebrew",
      "id": 1503512,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjE1MDM1MTI=",
      "avatar_url": "https://avatars.githubusercontent.com/u/1503512?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/Homebrew",
      "html_url": "https://github.com/Homebrew",
      "followers_url": "https://api.github.com/users/Homebrew/followers",
      "following_url": "https://api.github.com/users/Homebrew/following{/other_user}",
      "gists_url": "https://api.github.com/users/Homebrew/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/Homebrew/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/Homebrew/subscriptions",
      "organizations_url": "https://api.github.com/users/Homebrew/orgs",
      "repos_url": "https://api.github.com/users/Homebrew/repos",
      "events_url": "https://api.github.com/users/Homebrew/events{/privacy}",
      "received_events_url": "https://api.github.com/users/Homebrew/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/Homebrew/homebrew-core",
    "description": "🍻 Default formulae for the missing package manager for macOS (or Linux)",
    "fork": false,
    "url": "https://api.github.com/repos/Homebrew/homebrew-core",
    "forks_url": "https://api.github.com/repos/Homebrew/homebrew-core/forks",
    "keys_url": "https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/Homebrew/homebrew-core/teams",
    "hooks_url": "https://api.github.com/repos/Homebrew/homebrew-core/hooks",
    "issue_events_url": "https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}",
    "events_url": "https://api.github.com/repos/Homebrew/homebrew-core/events",
    "assignees_url": "https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}",
    "branches_url": "https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}",
    "tags_url": "https://api.github.com/repos/Homebrew/homebrew-core/tags",
    "blobs_url": "https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/Homebrew/homebrew-core/languages",
    "stargazers_url": "https://api.github.com/repos/Homebrew/homebrew-core/stargazers",
    "contributors_url": "https://api.github.com/repos/Homebrew/homebrew-core/contributors",
    "subscribers_url": "https://api.github.com/repos/Homebrew/homebrew-core/subscribers",
    "subscription_url": "https://api.github.com/repos/Homebrew/homebrew-core/subscription",
    "commits_url": "https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}",
    "compare_url": "https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/Homebrew/homebrew-core/merges",
    "archive_url": "https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/Homebrew/homebrew-core/downloads",
    "issues_url": "https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}",
    "pulls_url": "https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}",
    "releases_url": "https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}",
    "deployments_url": "https://api.github.com/repos/Homebrew/homebrew-core/deployments"
  },
  "head_repository": {
    "id": 535361402,
    "node_id": "R_kgDOH-j3eg",
    "name": "homebrew-core",
    "full_name": "ZhongRuoyu/homebrew-core",
    "private": false,
    "owner": {
      "login": "ZhongRuoyu",
      "id": 25842576,
      "node_id": "MDQ6VXNlcjI1ODQyNTc2",
      "avatar_url": "https://avatars.githubusercontent.com/u/25842576?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/ZhongRuoyu",
      "html_url": "https://github.com/ZhongRuoyu",
      "followers_url": "https://api.github.com/users/ZhongRuoyu/followers",
      "following_url": "https://api.github.com/users/ZhongRuoyu/following{/other_user}",
      "gists_url": "https://api.github.com/users/ZhongRuoyu/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/ZhongRuoyu/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/ZhongRuoyu/subscriptions",
      "organizations_url": "https://api.github.com/users/ZhongRuoyu/orgs",
      "repos_url": "https://api.github.com/users/ZhongRuoyu/repos",
      "events_url": "https://api.github.com/users/ZhongRuoyu/events{/privacy}",
      "received_events_url": "https://api.github.com/users/ZhongRuoyu/received_events",
      "type": "User",
      "site_admin": false
    },
    "html_url": "https://github.com/ZhongRuoyu/homebrew-core",
    "description": "🍻 Default formulae for the missing package manager for macOS (or Linux)",
    "fork": true,
    "url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core",
    "forks_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/forks",
    "keys_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/teams",
    "hooks_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/hooks",
    "issue_events_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/issues/events{/number}",
    "events_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/events",
    "assignees_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/assignees{/user}",
    "branches_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/branches{/branch}",
    "tags_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/tags",
    "blobs_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/languages",
    "stargazers_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/stargazers",
    "contributors_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/contributors",
    "subscribers_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/subscribers",
    "subscription_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/subscription",
    "commits_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/contents/{+path}",
    "compare_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/merges",
    "archive_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/downloads",
    "issues_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/issues{/number}",
    "pulls_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/labels{/name}",
    "releases_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/releases{/id}",
    "deployments_url": "https://api.github.com/repos/ZhongRuoyu/homebrew-core/deployments"
  }
}

carlocab
carlocab previously approved these changes Apr 18, 2023
@github-actions github-actions bot added this pull request to the merge queue Apr 18, 2023
@ZhongRuoyu ZhongRuoyu removed this pull request from the merge queue due to a manual request Apr 18, 2023
@ZhongRuoyu
Copy link
Member Author

@github-actions github-actions bot added this pull request to the merge queue 1 minute ago

@carlocab
Copy link
Member

Sorry, testing stuff. That didn't work 😅

@github-actions github-actions bot added this pull request to the merge queue Apr 18, 2023
@carlocab carlocab removed this pull request from the merge queue due to a manual request Apr 18, 2023
@carlocab carlocab added this pull request to the merge queue Apr 18, 2023
@carlocab carlocab removed this pull request from the merge queue due to a manual request Apr 18, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 18, 2023
@ZhongRuoyu ZhongRuoyu added CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Apr 18, 2023
@ZhongRuoyu ZhongRuoyu enabled auto-merge April 18, 2023 17:58
@ZhongRuoyu ZhongRuoyu requested a review from carlocab April 18, 2023 18:05
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Apr 18, 2023
Merged via the queue into Homebrew:master with commit bf31911 Apr 18, 2023
@ZhongRuoyu ZhongRuoyu deleted the bump-d2-0.4.1 branch April 18, 2023 18:26
@github-actions github-actions bot added the outdated PR was locked due to age label May 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants