-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH 821: PowerPoint Export #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the builder option makes sense, it doesn't need to be long templates, or a single tag each, just what makes sense for each call. builder is also used for svg rendering and the giant template option is hard to use
Yeah, I prefer the builder for sure, just not sure about what style. So leaving open for a discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it so small?
Kapture.2023-04-06.at.13.07.10.mp4
Let me check it.. |
oh what in the fuck, cool lol |
About the image size, it was an issue with integer division in |
It turns out that adding the links is a bit more complicated than I expected. So, I don't want to keep this one hanging because of links/sections as they can be separate PRs. Can you review this one then while I keep looking that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't review much of the voodoo going on in the construction, mostly just wanna make sure the interfacing with cli and tests are good
@ejulio-ts nah, it's a known issue, just add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add changelog plz
This fixes #821
PowerPoint (
.pptx
) files are just a bunch of XML files following the Office Open XML (OOXML) standard and then zipped.This adds a
pptx
lib that wraps all the logic to create these files around aPresentation
. There's a base template with the files that don't change and then the slides and some other required metadata are generated on the fly. The XML content was based on the content of an exported presentation. The intent here wasn't to create pptx library.Important in
pptx/pptx.go
I tested 3 different approaches to generate the XML files.getRelsSlideXml
)getPresentationXmlRels
)getAppXml
)I don't have any strong preference. The first one is quite complicated to update, as finding the template tags can be hard. The last one spans over many lines with long functions. So, open for ideas here and then I can use a single standard after this review. Just made it this way to see if there was some preference to keep.
Tested the resulting `.pptx. file on:
ToDo:
Below is the result for
app-flow.pptx
About the metadata, here's a screenshot