Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ~~ strikethrough work for markdown #819

Closed
bo-ku-ra opened this issue Feb 14, 2023 · 4 comments · Fixed by #1059
Closed

make ~~ strikethrough work for markdown #819

bo-ku-ra opened this issue Feb 14, 2023 · 4 comments · Fixed by #1059

Comments

@bo-ku-ra
Copy link
Contributor

https://d2lang.com/tour/style/#bold-italic-underline

style.strike-through: true
html: <s>foobar</s>
@cyborg-ts cyborg-ts added this to D2 Feb 14, 2023
@alixander
Copy link
Collaborator

i'm going to say no to this being a keyword because those are for labels, and i don't think it makes sense for a whole label to be strikethrough'd.

however, it should work for markdown: https://play.d2lang.com/?script=qrBSqMlN4VJQ0NIqycgs1tJSqKsrLinKzE4tySjKL03PqKvjquECBAAA__8%3D&

@alixander alixander changed the title proposal: strike-through make ~~ strikethrough work for markdown Mar 7, 2023
@bo-ku-ra
Copy link
Contributor Author

bo-ku-ra commented Mar 7, 2023

https://play.d2lang.com/?script=dJFBysIwFIT3OcV3gf67f5NFT-EFYn3owzQpfa1ttebsEkFw424GPoYZRhNdMAFlCWliysg6xKAJnai23-hyjBLOs0DUqxA4SswLTcvqVpoGq3rzPN6t_r42eP6flWm5ew4XNdTo8livJuXFmWfvTw5KGUa5aZ4tbh-iFLe737mvAAAA__8%3D&

@bo-ku-ra
Copy link
Contributor Author

bo-ku-ra commented Mar 7, 2023

#819 (comment)

however, it should work for markdown: https://play.d2lang.com/?script=qrBSqMlN4VJQ0NIqycgs1tJSqKsrLinKzE4tySjKL03PqKvjquECBAAA__8%3D&

not working.. (Windows only?)

@alixander
Copy link
Collaborator

sorry for the confusion, i meant "it should" as in, this is the TODO (we should make it work!)

@alixander alixander mentioned this issue Mar 18, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in D2 Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

strikethrough alixander/d2
2 participants
@alixander @bo-ku-ra