-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix precision difference for sketch mode running on different architectures #921
Comments
was a go compiler bug, nonissue after bumping to 1.20 #1020 |
sad, it was not. |
/bounty $220 (trying out this new service i saw on HN. it's an experiment to try to incentivize someone to solve this annoying thing no one wants to do. just a one-time thing for now) |
💎 $220.00 bounty created by alixander |
💡 ifndev submitted a pull request that claims the bounty. You can visit your org dashboard to reward. |
🎉🎈 @ifndev has been awarded $220.00! 🎈🎊 |
there's something inside here that's causing sketch tests to be different when run on
amd
andarm
architectures (e.g. M1 macbook and intel macbook).To reproduce:
Requires a machine that can run both architectures (I'm on M1 macbook which can run both), or VM environments or such
Run
GOARCH=arm64 TESTDATA_ACCEPT=1 ./ci/test.sh ./d2renderers/d2sketch/ -count=1
Notice nothing changes. (the red asterisk in my terminal means changed files). This is the architecture that our CI runs on.
Run
GOARCH=amd64 TESTDATA_ACCEPT=1 ./ci/test.sh ./d2renderers/d2sketch/ -count=1
Notice there are changes!
I'm not sure if this issue is in rough.js, the JS engine (goja), rounding on architectures, or something in our code reading/writing data from/to rough.js.
The text was updated successfully, but these errors were encountered: