Class and sqltable border radius

[ShupingHe]

closes #689
this pr add support for apply border-radius to class and sql_table

the image below can be generate by run ./ci/e2ereport.sh -test-case=class_and_sqlTable_border_radius:

[ShupingHe]

@alixander after fetch the remote repo, seems like there are something wrong with my local env, do you have any ideas how to resolve it? i already asked in discord help channel.

unexpected error: failed to wait xmain test: e2etests-cli/d2: fdopendir /usr/bin/gem: not a directory

[alixander]

hey @donglixiaoche i responded in Discord but copying here:

i think this is an issue with something in your PATH, like you have gem in your PATH pointing to a wrong directory

can you double check your PATH?

[alixander]

these look great. sorry can you add this test to d2sketch_test as well? I just want to make sure it works there too, then we can merge

[ShupingHe]

@alixander already regenerated some tests. seems like these changes have no effect on d2Sketch, do i need to fix it?

[alixander]

@alixander already regenerated some tests. seems like these changes have no effect on d2Sketch, do i need to fix it?

no it's not a big deal, as long as not broken

[ShupingHe]

@alixander one thing need to discuss with you is, althought these changes work well, but the logic for rendering border-radius is distributed between different files. isn't it hard to maintain?

[alixander]

@alixander one thing need to discuss with you is, althought these changes work well, but the logic for rendering border-radius is distributed between different files. isn't it hard to maintain?

yeah it's unfortunate. i didn't expect class and table to deviate so much from d2svg's main rendering. eventually we should consolidate in a refactor

[ShupingHe]

@alixander still some little changes even i just add rx and ry for rect with non-zero border-radius, is that normal?

[alixander]

@donglixiaoche for the sketch tests? yeah, there's some tiiny precision issue dependent on architecture. what machine are u running? #921

[ShupingHe]

but i regenerate those testcases anyway, do i need revert it?

[alixander]

but i regenerate those testcases anyway, do i need revert it?

@donglixiaoche yes please revert it. sorry about that.

as well as the CLI tests: e2etests-cli/testdata/TestCLI_E2E/hello_world_png_sketch.exp.png

[ShupingHe]

but i regenerate those testcases anyway, do i need revert it?

@donglixiaoche yes please revert it. sorry about that.

as well as the CLI tests: e2etests-cli/testdata/TestCLI_E2E/hello_world_png_sketch.exp.png

@alixander done, ./make.sh still passed, sry, my bad, i thought it's part of our ci process

[alixander]

tested locally and works well! thanks for taking such a tedious one. classes and sql_tables are some of the most used shapes people use D2 for, so i'm sure we'll start seeing some usages of these in no time

[alixander]

beautiful (code, commit msgs, and resulting diagrams)!