Isolate css #1016
Merged
Isolate css #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS and font targeting needs to be diagram-specific.
Imagine you have two embedded D2 SVGs on a web page. They both say "fill-N1" should be a certain color, as dictated by their theme. Well the second one that says that will win, overwriting the CSS of the first diagram.
The fix is to give the outer SVG unique diagram ID class, and then all the CSS rules target elements that are descendants of that class.
All the tests change because of diagram hash change. But I've visually checked each test to make sure nothing rendered different.
Without this change, it wasn't possible to do this, since the font styles of the second one overrides the font styles of the first.
closes #972